Commit 2100c9b0 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

drm/i915/gvt: remove local storage of debugfs file 



There is no need to keep the dentry around for the debugfs kvmgt cache
file, as we can just look it up when we want to remove it later on.
Simplify the structure by removing the dentry and relying on debugfs
to find the dentry to remove when we want to.

By doing this change, we remove the last in-kernel user that was storing
the result of debugfs_create_long(), so that api can be cleaned up.

Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gvt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: default avatarZhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20210518161705.3697143-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e1327a12

drivers/gpu/drm/i915/gvt/kvmgt.c

+5 −6
Original line number Diff line number Diff line
@@ -88,6 +88,7 @@ struct kvmgt_pgfn { 
	struct hlist_node hnode;

};



#define KVMGT_DEBUGFS_FILENAME "kvmgt_nr_cache_entries"

struct kvmgt_guest_info {

	struct kvm *kvm;

	struct intel_vgpu *vgpu;
@@ -95,7 +96,6 @@ struct kvmgt_guest_info { 
#define NR_BKT (1 << 18)

	struct hlist_head ptable[NR_BKT];

#undef NR_BKT

	struct dentry *debugfs_cache_entries;

};



struct gvt_dma {
@@ -1843,16 +1843,15 @@ static int kvmgt_guest_init(struct mdev_device *mdev) 
	info->track_node.track_flush_slot = kvmgt_page_track_flush_slot;

	kvm_page_track_register_notifier(kvm, &info->track_node);



	info->debugfs_cache_entries = debugfs_create_ulong(

						"kvmgt_nr_cache_entries",

						0444, vgpu->debugfs,

	debugfs_create_ulong(KVMGT_DEBUGFS_FILENAME, 0444, vgpu->debugfs,

			     &vdev->nr_cache_entries);

	return 0;

}



static bool kvmgt_guest_exit(struct kvmgt_guest_info *info)

{

	debugfs_remove(info->debugfs_cache_entries);

	debugfs_remove(debugfs_lookup(KVMGT_DEBUGFS_FILENAME,

				      info->vgpu->debugfs));



	kvm_page_track_unregister_notifier(info->kvm, &info->track_node);

	kvm_put_kvm(info->kvm);