Commit 2135e5d5 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4/pnfs: Fix a use-after-free bug in open 



If someone cancels the open RPC call, then we must not try to free
either the open slot or the layoutget operation arguments, since they
are likely still in use by the hung RPC call.

Fixes: 69494938 ("NFSv4: Don't hold the layoutget locks across multiple RPC calls")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent b1a28f2e

fs/nfs/nfs4proc.c

+6 −5
Original line number Diff line number Diff line
@@ -3096,12 +3096,13 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, 
	}



out:

	if (!opendata->cancelled) {

		if (opendata->lgp) {

			nfs4_lgopen_release(opendata->lgp);

			opendata->lgp = NULL;

		}

	if (!opendata->cancelled)

		nfs4_sequence_free_slot(&opendata->o_res.seq_res);

	}

	return ret;

}