Commit 220ac8d1 authored by yu kuai's avatar yu kuai Committed by Alex Deucher
Browse files

drm/amdgpu: remove always false comparison in 'amdgpu_atombios_i2c_process_i2c_ch' 



Fixes gcc '-Wtype-limits' warning:

drivers/gpu/drm/amd/amdgpu/atombios_i2c.c: In function
‘amdgpu_atombios_i2c_process_i2c_ch’:
drivers/gpu/drm/amd/amdgpu/atombios_i2c.c:79:11: warning: comparison is
always false due to limited range of data type [-Wtype-limits]

'num' is 'u8', so it will never be greater than 'TOM_MAX_HW_I2C_READ',
which is defined as 255. Therefore, the comparison can be removed.

Fixes: d38ceaf9 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: default avataryu kuai <yukuai3@huawei.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent d1d09dc4

drivers/gpu/drm/amd/amdgpu/atombios_i2c.c

+0 −5
Original line number Diff line number Diff line
@@ -76,11 +76,6 @@ static int amdgpu_atombios_i2c_process_i2c_ch(struct amdgpu_i2c_chan *chan, 
		}

		args.lpI2CDataOut = cpu_to_le16(out);

	} else {

		if (num > ATOM_MAX_HW_I2C_READ) {

			DRM_ERROR("hw i2c: tried to read too many bytes (%d vs 255)\n", num);

			r = -EINVAL;

			goto done;

		}

		args.ucRegIndex = 0;

		args.lpI2CDataOut = 0;

	}