Commit 22667e6e authored by Harry Wentland's avatar Harry Wentland Committed by Alex Deucher
Browse files

drm/amd/display: Pass display_pipe_params_st as const in DML 



[Why]
This neither needs to be on the stack nor passed by value
to each function call. In fact, when building with clang
it seems to break the Linux's default 1024 byte stack
frame limit.

[How]
We can simply pass this as a const pointer.

This patch fixes these Coverity IDs
Addresses-Coverity-ID: 1424031: ("Big parameter passed by value")
Addresses-Coverity-ID: 1423970: ("Big parameter passed by value")
Addresses-Coverity-ID: 1423941: ("Big parameter passed by value")
Addresses-Coverity-ID: 1451742: ("Big parameter passed by value")
Addresses-Coverity-ID: 1451887: ("Big parameter passed by value")
Addresses-Coverity-ID: 1454146: ("Big parameter passed by value")
Addresses-Coverity-ID: 1454152: ("Big parameter passed by value")
Addresses-Coverity-ID: 1454413: ("Big parameter passed by value")
Addresses-Coverity-ID: 1466144: ("Big parameter passed by value")
Addresses-Coverity-ID: 1487237: ("Big parameter passed by value")

Signed-off-by: default avatarHarry Wentland <harry.wentland@amd.com>
Fixes: 3fe617cc ("Enable '-Werror' by default for all kernel builds")
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Arnd Bergmann <arnd@kernel.org>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Xinhui Pan <Xinhui.Pan@amd.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: llvm@lists.linux.dev
Acked-by: default avatarChristian König <christian.koenig@amd.com>
Build-tested-by: default avatarNathan Chancellor <nathan@kernel.org>
Reviewed-by: default avatarLeo Li <sunpeng.li@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e7eb2137

drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c

+1 −1
Original line number Diff line number Diff line
@@ -3176,7 +3176,7 @@ void dcn20_calculate_dlg_params( 


		context->bw_ctx.dml.funcs.rq_dlg_get_rq_reg(&context->bw_ctx.dml,

				&context->res_ctx.pipe_ctx[i].rq_regs,

				pipes[pipe_idx].pipe);

				&pipes[pipe_idx].pipe);

		pipe_idx++;

	}

}

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c

+3 −3
Original line number Diff line number Diff line
@@ -768,12 +768,12 @@ static void dml20_rq_dlg_get_rq_params(struct display_mode_lib *mode_lib, 


void dml20_rq_dlg_get_rq_reg(struct display_mode_lib *mode_lib,

		display_rq_regs_st *rq_regs,

		const display_pipe_params_st pipe_param)

		const display_pipe_params_st *pipe_param)

{

	display_rq_params_st rq_param = {0};



	memset(rq_regs, 0, sizeof(*rq_regs));

	dml20_rq_dlg_get_rq_params(mode_lib, &rq_param, pipe_param.src);

	dml20_rq_dlg_get_rq_params(mode_lib, &rq_param, pipe_param->src);

	extract_rq_regs(mode_lib, rq_regs, rq_param);



	print__rq_regs_st(mode_lib, *rq_regs);
@@ -1549,7 +1549,7 @@ static void dml20_rq_dlg_get_dlg_params(struct display_mode_lib *mode_lib, 
void dml20_rq_dlg_get_dlg_reg(struct display_mode_lib *mode_lib,

		display_dlg_regs_st *dlg_regs,

		display_ttu_regs_st *ttu_regs,

		display_e2e_pipe_params_st *e2e_pipe_param,

		const display_e2e_pipe_params_st *e2e_pipe_param,

		const unsigned int num_pipes,

		const unsigned int pipe_idx,

		const bool cstate_en,

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.h

+2 −2
Original line number Diff line number Diff line
@@ -43,7 +43,7 @@ struct display_mode_lib; 
void dml20_rq_dlg_get_rq_reg(

		struct display_mode_lib *mode_lib,

		display_rq_regs_st *rq_regs,

		const display_pipe_params_st pipe_param);

		const display_pipe_params_st *pipe_param);





// Function: dml_rq_dlg_get_dlg_reg
@@ -61,7 +61,7 @@ void dml20_rq_dlg_get_dlg_reg( 
		struct display_mode_lib *mode_lib,

		display_dlg_regs_st *dlg_regs,

		display_ttu_regs_st *ttu_regs,

		display_e2e_pipe_params_st *e2e_pipe_param,

		const display_e2e_pipe_params_st *e2e_pipe_param,

		const unsigned int num_pipes,

		const unsigned int pipe_idx,

		const bool cstate_en,

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c

+3 −3
Original line number Diff line number Diff line
@@ -768,12 +768,12 @@ static void dml20v2_rq_dlg_get_rq_params(struct display_mode_lib *mode_lib, 


void dml20v2_rq_dlg_get_rq_reg(struct display_mode_lib *mode_lib,

		display_rq_regs_st *rq_regs,

		const display_pipe_params_st pipe_param)

		const display_pipe_params_st *pipe_param)

{

	display_rq_params_st rq_param = {0};



	memset(rq_regs, 0, sizeof(*rq_regs));

	dml20v2_rq_dlg_get_rq_params(mode_lib, &rq_param, pipe_param.src);

	dml20v2_rq_dlg_get_rq_params(mode_lib, &rq_param, pipe_param->src);

	extract_rq_regs(mode_lib, rq_regs, rq_param);



	print__rq_regs_st(mode_lib, *rq_regs);
@@ -1550,7 +1550,7 @@ static void dml20v2_rq_dlg_get_dlg_params(struct display_mode_lib *mode_lib, 
void dml20v2_rq_dlg_get_dlg_reg(struct display_mode_lib *mode_lib,

		display_dlg_regs_st *dlg_regs,

		display_ttu_regs_st *ttu_regs,

		display_e2e_pipe_params_st *e2e_pipe_param,

		const display_e2e_pipe_params_st *e2e_pipe_param,

		const unsigned int num_pipes,

		const unsigned int pipe_idx,

		const bool cstate_en,

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.h

+2 −2
Original line number Diff line number Diff line
@@ -43,7 +43,7 @@ struct display_mode_lib; 
void dml20v2_rq_dlg_get_rq_reg(

		struct display_mode_lib *mode_lib,

		display_rq_regs_st *rq_regs,

		const display_pipe_params_st pipe_param);

		const display_pipe_params_st *pipe_param);





// Function: dml_rq_dlg_get_dlg_reg
@@ -61,7 +61,7 @@ void dml20v2_rq_dlg_get_dlg_reg( 
		struct display_mode_lib *mode_lib,

		display_dlg_regs_st *dlg_regs,

		display_ttu_regs_st *ttu_regs,

		display_e2e_pipe_params_st *e2e_pipe_param,

		const display_e2e_pipe_params_st *e2e_pipe_param,

		const unsigned int num_pipes,

		const unsigned int pipe_idx,

		const bool cstate_en,