Commit 22804e03 authored by Felix Kuehling's avatar Felix Kuehling Committed by Alex Deucher
Browse files

drm/amdkfd: Fix criu_restore_bo error handling 



Clang static analysis reports this problem
kfd_chardev.c:2327:2: warning: 1st function call argument
  is an uninitialized value
  kvfree(bo_privs);
  ^~~~~~~~~~~~~~~~

Make sure bo_buckets and bo_privs are initialized so freeing them in the
error handling code path will never result in undefined behaviour.

Fixes: 73fa13b6 ("drm/amdkfd: CRIU Implement KFD restore ioctl")
Reported-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: default avatarRajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 757f9e4d

drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

+2 −2
Original line number Diff line number Diff line
@@ -2097,8 +2097,8 @@ static int criu_restore_bos(struct kfd_process *p, 
			    uint64_t *priv_offset,

			    uint64_t max_priv_data_size)

{

	struct kfd_criu_bo_bucket *bo_buckets;

	struct kfd_criu_bo_priv_data *bo_privs;

	struct kfd_criu_bo_bucket *bo_buckets = NULL;

	struct kfd_criu_bo_priv_data *bo_privs = NULL;

	const bool criu_resume = true;

	bool flush_tlbs = false;

	int ret = 0, j = 0;