Commit 22af4990 authored by Jérôme Pouiller's avatar Jérôme Pouiller Committed by Greg Kroah-Hartman
Browse files

staging: wfx: use abbreviated message for "incorrect sequence" 



The wfx driver checks carefully the coherency of of the DTIM
notifications. We have noticed several times some small inconsistencies
from the firmware on these notification. They have never been critical.

However on the driver side they lead to big fat warnings. Worse, if
these warning are displayed on UART console, they can be long to display
(several hundreds of millisecs). Since, this warning is generated from a
work queue, it can delay all the workqueue users. Especially, it can
drastically slow down the frame management of the driver and then
generate errors that are serious this time (eg. an overflow of the
indication queue of the device).

Signed-off-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20210913130203.1903622-2-Jerome.Pouiller@silabs.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e5a922a6

drivers/staging/wfx/sta.c

+3 −2
Original line number Diff line number Diff line
@@ -631,8 +631,9 @@ void wfx_suspend_resume_mc(struct wfx_vif *wvif, enum sta_notify_cmd notify_cmd) 
{

	if (notify_cmd != STA_NOTIFY_AWAKE)

		return;

	WARN(!wfx_tx_queues_has_cab(wvif), "incorrect sequence");

	WARN(wvif->after_dtim_tx_allowed, "incorrect sequence");

	if (!wfx_tx_queues_has_cab(wvif) || wvif->after_dtim_tx_allowed)

		dev_warn(wvif->wdev->dev, "incorrect sequence (%d CAB in queue)",

			 wfx_tx_queues_has_cab(wvif));

	wvif->after_dtim_tx_allowed = true;

	wfx_bh_request_tx(wvif->wdev);

}