Commit 22e395d0 authored by Damien Le Moal's avatar Damien Le Moal
Browse files

ata: pata_parport: Fix bpck module code indentation and style 



Fix the header, indentation and coding style in the bpck pata parport
protocol module to suppress smatch warnings such as:

drivers/ata/pata_parport/bpck.c:66 bpck_read_regr() warn: inconsistent indenting

No functional changes.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202305021913.nCMzH5Zj-lkp@intel.com/


Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
parent 12e2e17d

drivers/ata/pata_parport/bpck.c

+266 −200
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-or-later

/*

	bpck.c	(c) 1996-8  Grant R. Guenther <grant@torque.net>

		            Under the terms of the GNU General Public License.



	bpck.c is a low-level protocol driver for the MicroSolutions 

	"backpack" parallel port IDE adapter.  



 * (c) 1996-1998  Grant R. Guenther <grant@torque.net>

 *

 * bpck.c is a low-level protocol driver for the MicroSolutions

 * "backpack" parallel port IDE adapter.

 */



#include <linux/module.h>
@@ -29,36 +28,36 @@ 


#define j44(l,h)     (((l>>3)&0x7)|((l>>4)&0x8)|((h<<1)&0x70)|(h&0x80))



/* cont = 0 - access the IDE register file 

   cont = 1 - access the IDE command set 

   cont = 2 - use internal bpck register addressing

/*

 * cont = 0 - access the IDE register file

 * cont = 1 - access the IDE command set

 * cont = 2 - use internal bpck register addressing

 */



static int  cont_map[3] = { 0x40, 0x48, 0 };



static int bpck_read_regr(struct pi_adapter *pi, int cont, int regr)



{       int r, l, h;

{

	int r, l, h;



	r = regr + cont_map[cont];



	switch (pi->mode) {



	case 0: w0(r & 0xf); w0(r); t2(2); t2(4);

	case 0:

		w0(r & 0xf); w0(r); t2(2); t2(4);

	        l = r1();

		t2(4);

		h = r1();

		return j44(l, h);



	case 1: w0(r & 0xf); w0(r); t2(2);

	case 1:

		w0(r & 0xf); w0(r); t2(2);

		e2(); t2(0x20);

		t2(4); h = r0();

		t2(1); t2(0x20);

		return h;



	case 2:

	case 3:

	case 4: w0(r); w2(9); w2(0); w2(0x20);

	case 4:

		w0(r); w2(9); w2(0); w2(0x20);

		h = r4();

		w2(0);

		return h;
@@ -68,20 +67,18 @@ static int bpck_read_regr(struct pi_adapter *pi, int cont, int regr) 
}



static void bpck_write_regr(struct pi_adapter *pi, int cont, int regr, int val)



{	int	r;

{

	int r;



        r = regr + cont_map[cont];



	switch (pi->mode) {



	case 0:

	case 1: w0(r);

		t2(2);

		w0(val);

		o2(); t2(4); t2(1);

		break;



	case 2:

	case 3:

	case 4: w0(r); w2(9); w2(0);
@@ -97,40 +94,54 @@ static void bpck_write_regr(struct pi_adapter *pi, int cont, int regr, int val) 
#define RR(r)		(bpck_read_regr(pi,2,r))



static void bpck_write_block(struct pi_adapter *pi, char *buf, int count)



{	int i;

{

	int i;



	switch (pi->mode) {



	case 0: WR(4,0x40);

	case 0:

		WR(4, 0x40);

		w0(0x40); t2(2); t2(1);

		for (i=0;i<count;i++) { w0(buf[i]); t2(4); }

		for (i = 0; i < count; i++) {

			w0(buf[i]);

			t2(4);

		}

		WR(4, 0);

		break;



	case 1: WR(4,0x50);

	case 1:

		WR(4, 0x50);

		w0(0x40); t2(2); t2(1);

                for (i=0;i<count;i++) { w0(buf[i]); t2(4); }

		for (i = 0; i < count; i++) {

			w0(buf[i]);

			t2(4);

		}

		WR(4, 0x10);

		break;



	case 2: WR(4,0x48);

	case 2:

		WR(4, 0x48);

		w0(0x40); w2(9); w2(0); w2(1);

		for (i=0;i<count;i++) w4(buf[i]);

		for (i = 0; i < count; i++)

			w4(buf[i]);

		w2(0);

		WR(4, 8);

		break;



        case 3: WR(4,0x48);

	case 3:

		WR(4, 0x48);

		w0(0x40); w2(9); w2(0); w2(1);

                for (i=0;i<count/2;i++) w4w(((u16 *)buf)[i]);

		for (i = 0; i < count / 2; i++)

			w4w(((u16 *)buf)[i]);

		w2(0);

		WR(4, 8);

		break;



        case 4: WR(4,0x48);

	case 4:

		WR(4, 0x48);

		w0(0x40); w2(9); w2(0); w2(1);

                for (i=0;i<count/4;i++) w4l(((u32 *)buf)[i]);

		for (i = 0; i < count / 4; i++)

			w4l(((u32 *)buf)[i]);

		w2(0);

		WR(4, 8);

		break;
@@ -138,12 +149,13 @@ static void bpck_write_block(struct pi_adapter *pi, char *buf, int count) 
}



static void bpck_read_block(struct pi_adapter *pi, char *buf, int count)



{	int i, l, h;

{

	int i, l, h;



	switch (pi->mode) {



      	case 0: WR(4,0x40);

	case 0:

		WR(4, 0x40);

		w0(0x40); t2(2);

		for (i = 0; i < count; i++) {

			t2(4); l = r1();
@@ -153,30 +165,40 @@ static void bpck_read_block(struct pi_adapter *pi, char *buf, int count) 
		WR(4, 0);

		break;



	case 1: WR(4,0x50);

	case 1:

		WR(4, 0x50);

		w0(0x40); t2(2); t2(0x20);

      	        for(i=0;i<count;i++) { t2(4); buf[i] = r0(); }

		for (i = 0; i < count; i++) {

			t2(4);

			buf[i] = r0();

		}

		t2(1); t2(0x20);

		WR(4, 0x10);

		break;



	case 2: WR(4,0x48);

	case 2:

		WR(4, 0x48);

		w0(0x40); w2(9); w2(0); w2(0x20);

		for (i=0;i<count;i++) buf[i] = r4();

		for (i = 0; i < count; i++)

			buf[i] = r4();

		w2(0);

		WR(4, 8);

		break;



        case 3: WR(4,0x48);

	case 3:

		WR(4, 0x48);

		w0(0x40); w2(9); w2(0); w2(0x20);

                for (i=0;i<count/2;i++) ((u16 *)buf)[i] = r4w();

		for (i = 0; i < count / 2; i++)

			((u16 *)buf)[i] = r4w();

		w2(0);

		WR(4, 8);

		break;



        case 4: WR(4,0x48);

	case 4:

		WR(4, 0x48);

		w0(0x40); w2(9); w2(0); w2(0x20);

                for (i=0;i<count/4;i++) ((u32 *)buf)[i] = r4l();

		for (i = 0; i < count / 4; i++)

			((u32 *)buf)[i] = r4l();

		w2(0);

		WR(4, 8);

		break;
@@ -185,8 +207,8 @@ static void bpck_read_block(struct pi_adapter *pi, char *buf, int count) 
}



static int bpck_probe_unit(struct pi_adapter *pi)



{	int o1, o0, f7, id;

{

	int o1, o0, f7, id;

	int t, s;



	id = pi->unit;
@@ -198,7 +220,10 @@ static int bpck_probe_unit(struct pi_adapter *pi) 
	t2(8); t2(8); t2(8);

	t2(2); t = r1()&0xf8;

	f7 = ((id % 8) == 7);

	if ((f7) || (t != o1)) { t2(2); s = r1()&0xf8; }

	if ((f7) || (t != o1)) {

		t2(2);

		s = r1() & 0xf8;

	}

	if ((t == o1) && ((!f7) || (s == o1)))  {

		w2(0x4c); w0(o0);

		return 0;
@@ -208,31 +233,33 @@ static int bpck_probe_unit(struct pi_adapter *pi) 
}



static void bpck_connect(struct pi_adapter *pi)



{       pi->saved_r0 = r0();

{

	pi->saved_r0 = r0();

	w0(0xff-pi->unit); w2(4); w0(pi->unit);

	t2(8); t2(8); t2(8);

	t2(2); t2(2);



	switch (pi->mode) {



	case 0: t2(8); WR(4,0);

	case 0:

		t2(8); WR(4, 0);

		break;



	case 1: t2(8); WR(4,0x10);

	case 1:

		t2(8); WR(4, 0x10);

		break;



	case 2:

	case 3:

	case 4: w2(0); WR(4,8);

	case 4:

		w2(0); WR(4, 8);

		break;



	}



	WR(5,8);



/*	if (pi->devtype == PI_PCD) {	possibly wrong, purpose unknown */

		WR(0x46,0x10);		/* fiddle with ESS logic ??? */

	/*

	 * Possibly wrong, purpose unknown (fiddle with ESS logic ???)

	 * if (pi->devtype == PI_PCD) {

	 */

	WR(0x46, 0x10);

	WR(0x4c, 0x38);

	WR(0x4d, 0x88);

	WR(0x46, 0xa0);
@@ -242,17 +269,20 @@ static void bpck_connect(struct pi_adapter *pi) 
}



static void bpck_disconnect(struct pi_adapter *pi)



{	w0(0); 

	if (pi->mode >= 2) { w2(9); w2(0); } else t2(2);

{

	w0(0);

	if (pi->mode >= 2) {

		w2(9); w2(0);

	} else {

		t2(2);

	}

	w2(0x4c); w0(pi->saved_r0);

}



static void bpck_force_spp(struct pi_adapter *pi)



{

	/* This fakes the EPP protocol to turn off EPP ... */



{       pi->saved_r0 = r0();

	pi->saved_r0 = r0();

	w0(0xff-pi->unit); w2(4); w0(pi->unit);

	t2(8); t2(8); t2(8);

	t2(2); t2(2);
@@ -267,15 +297,16 @@ static void bpck_force_spp(struct pi_adapter *pi) 
#define TEST_LEN  16



static int bpck_test_proto(struct pi_adapter *pi)



{	int i, e, l, h, om;

{

	int i, e, l, h, om;

	char buf[TEST_LEN];



	bpck_force_spp(pi);



	switch (pi->mode) {



	case 0: bpck_connect(pi);

	case 0:

		bpck_connect(pi);

		WR(0x13, 0x7f);

		w0(0x13); t2(2);

		for (i = 0; i < TEST_LEN; i++) {
@@ -286,17 +317,22 @@ static int bpck_test_proto(struct pi_adapter *pi) 
		bpck_disconnect(pi);

		break;



        case 1: bpck_connect(pi);

	case 1:

		bpck_connect(pi);

		WR(0x13, 0x7f);

		w0(0x13); t2(2); t2(0x20);

                for(i=0;i<TEST_LEN;i++) { t2(4); buf[i] = r0(); }

		for (i = 0; i < TEST_LEN; i++) {

			t2(4);

			buf[i] = r0();

		}

		t2(1); t2(0x20);

		bpck_disconnect(pi);

		break;



	case 2:

	case 3:

	case 4: om = pi->mode;

	case 4:

		om = pi->mode;

		pi->mode = 0;

		bpck_connect(pi);

		WR(7, 3);
@@ -308,34 +344,44 @@ static int bpck_test_proto(struct pi_adapter *pi) 
		w0(0x13); w2(9); w2(1); w0(0); w2(3); w2(0); w2(0xe0);



		switch (pi->mode) {

		  case 2: for (i=0;i<TEST_LEN;i++) buf[i] = r4();

		case 2:

			for (i = 0; i < TEST_LEN; i++)

				buf[i] = r4();

			break;

		  case 3: for (i=0;i<TEST_LEN/2;i++) ((u16 *)buf)[i] = r4w();

		case 3:

			for (i = 0; i < TEST_LEN / 2; i++)

				((u16 *)buf)[i] = r4w();

			break;

		  case 4: for (i=0;i<TEST_LEN/4;i++) ((u32 *)buf)[i] = r4l();

		case 4:

			for (i = 0; i < TEST_LEN / 4; i++)

				((u32 *)buf)[i] = r4l();

			break;

		}



		w2(0);

		WR(7, 0);

		bpck_disconnect(pi);



		break;



	}



	dev_dbg(&pi->dev, "bpck: 0x%x unit %d mode %d: ",

		pi->port, pi->unit, pi->mode);

	print_hex_dump_debug("bpck: ", DUMP_PREFIX_NONE, TEST_LEN, 1, buf, TEST_LEN, false);

	print_hex_dump_debug("bpck: ", DUMP_PREFIX_NONE, TEST_LEN, 1, buf,

			     TEST_LEN, false);



	e = 0;

	for (i=0;i<TEST_LEN;i++) if (buf[i] != (i+1)) e++;

	for (i = 0; i < TEST_LEN; i++) {

		if (buf[i] != i + 1)

			e++;

	}



	return e;

}



static void bpck_read_eeprom(struct pi_adapter *pi, char *buf)



{       int i, j, k, p, v, f, om, od;

{

	int i, j, k, p, v, f, om, od;



	bpck_force_spp(pi);
@@ -384,36 +430,56 @@ static void bpck_read_eeprom(struct pi_adapter *pi, char *buf) 
	pi->mode = om; pi->delay = od;

}



static int bpck_test_port(struct pi_adapter *pi)	/* check for 8-bit port */



{	int	i, r, m;

static int bpck_test_port(struct pi_adapter *pi)

{

	int i, r, m;



	/* Check for 8-bit port */

	w2(0x2c); i = r0(); w0(255-i); r = r0(); w0(i);

	m = -1;

	if (r == i) m = 2;

	if (r == (255-i)) m = 0;

	if (r == i)

		m = 2;

	if (r == (255-i))

		m = 0;



	w2(0xc);

	i = r0();

	w0(255-i);

	r = r0();

	w0(i);

	if (r != (255-i))

		m = -1;



	w2(0xc); i = r0(); w0(255-i); r = r0(); w0(i);

	if (r != (255-i)) m = -1;

	if (m == 0) {

		w2(6);

		w2(0xc);

		r = r0();

		w0(0xaa);

		w0(r);

		w0(0xaa);

	}

	if (m == 2) {

		w2(0x26);

		w2(0xc);

	}



	if (m == 0) { w2(6); w2(0xc); r = r0(); w0(0xaa); w0(r); w0(0xaa); }

	if (m == 2) { w2(0x26); w2(0xc); }

	if (m == -1)

		return 0;



	if (m == -1) return 0;

	return 5;

}



static void bpck_log_adapter(struct pi_adapter *pi)



{	char	*mode_string[5] = { "4-bit","8-bit","EPP-8",

				    "EPP-16","EPP-32" };

{

	char *mode_str[5] = { "4-bit", "8-bit", "EPP-8", "EPP-16", "EPP-32" };

	char scratch[128];



	bpck_read_eeprom(pi,scratch);

	print_hex_dump_bytes("bpck EEPROM: ", DUMP_PREFIX_NONE, scratch, 128);

	dev_info(&pi->dev, "backpack %8.8s unit %d at 0x%x, mode %d (%s), delay %d\n",

	dev_info(&pi->dev,

		 "backpack %8.8s unit %d at 0x%x, mode %d (%s), delay %d\n",

		 &scratch[110], pi->unit, pi->port, pi->mode,

		 mode_string[pi->mode], pi->delay);

		 mode_str[pi->mode], pi->delay);

}



static struct pi_protocol bpck = {