Commit 2338e7bc authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Rafael J. Wysocki
Browse files

device property: Remove device_add_properties() API 



There are no more users for it.

Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 982b94ba

drivers/base/property.c

+0 −48
Original line number Diff line number Diff line
@@ -507,54 +507,6 @@ struct fwnode_handle *fwnode_find_reference(const struct fwnode_handle *fwnode, 
}

EXPORT_SYMBOL_GPL(fwnode_find_reference);



/**

 * device_remove_properties - Remove properties from a device object.

 * @dev: Device whose properties to remove.

 *

 * The function removes properties previously associated to the device

 * firmware node with device_add_properties(). Memory allocated to the

 * properties will also be released.

 */

void device_remove_properties(struct device *dev)

{

	struct fwnode_handle *fwnode = dev_fwnode(dev);



	if (!fwnode)

		return;



	if (is_software_node(fwnode->secondary)) {

		fwnode_remove_software_node(fwnode->secondary);

		set_secondary_fwnode(dev, NULL);

	}

}

EXPORT_SYMBOL_GPL(device_remove_properties);



/**

 * device_add_properties - Add a collection of properties to a device object.

 * @dev: Device to add properties to.

 * @properties: Collection of properties to add.

 *

 * Associate a collection of device properties represented by @properties with

 * @dev. The function takes a copy of @properties.

 *

 * WARNING: The callers should not use this function if it is known that there

 * is no real firmware node associated with @dev! In that case the callers

 * should create a software node and assign it to @dev directly.

 */

int device_add_properties(struct device *dev,

			  const struct property_entry *properties)

{

	struct fwnode_handle *fwnode;



	fwnode = fwnode_create_software_node(properties, NULL);

	if (IS_ERR(fwnode))

		return PTR_ERR(fwnode);



	set_secondary_fwnode(dev, fwnode);

	return 0;

}

EXPORT_SYMBOL_GPL(device_add_properties);



/**

 * fwnode_get_name - Return the name of a node

 * @fwnode: The firmware node

include/linux/property.h

+0 −4
Original line number Diff line number Diff line
@@ -378,10 +378,6 @@ property_entries_dup(const struct property_entry *properties); 


void property_entries_free(const struct property_entry *properties);



int device_add_properties(struct device *dev,

			  const struct property_entry *properties);

void device_remove_properties(struct device *dev);



bool device_dma_supported(struct device *dev);



enum dev_dma_attr device_get_dma_attr(struct device *dev);