Commit 23b3d1cf authored by Ranjan Kumar's avatar Ranjan Kumar Committed by Martin K. Petersen
Browse files

scsi: mpi3mr: Fix admin queue memory leak upon soft reset 



After a soft reset, while setting up admin queue pairs, the driver
initially sets admin request base and admin reply base addresses to
NULL. This leads to DMA memory pointed by these pointers getting leaked.

Signed-off-by: default avatarRanjan Kumar <ranjan.kumar@broadcom.com>
Signed-off-by: default avatarSreekanth Reddy <sreekanth.reddy@broadcom.com>
Link: https://lore.kernel.org/r/20230316110209.60145-3-ranjan.kumar@broadcom.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3f1254ed

drivers/scsi/mpi3mr/mpi3mr_fw.c

+0 −2
Original line number Diff line number Diff line
@@ -2597,14 +2597,12 @@ static int mpi3mr_setup_admin_qpair(struct mpi3mr_ioc *mrioc) 
	mrioc->num_admin_req = mrioc->admin_req_q_sz /

	    MPI3MR_ADMIN_REQ_FRAME_SZ;

	mrioc->admin_req_ci = mrioc->admin_req_pi = 0;

	mrioc->admin_req_base = NULL;



	mrioc->admin_reply_q_sz = MPI3MR_ADMIN_REPLY_Q_SIZE;

	mrioc->num_admin_replies = mrioc->admin_reply_q_sz /

	    MPI3MR_ADMIN_REPLY_FRAME_SZ;

	mrioc->admin_reply_ci = 0;

	mrioc->admin_reply_ephase = 1;

	mrioc->admin_reply_base = NULL;



	if (!mrioc->admin_req_base) {

		mrioc->admin_req_base = dma_alloc_coherent(&mrioc->pdev->dev,