Commit 24001039 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: adv_pci1723: remove private data 'da_range' 



This member of the private data is initialized to 0 by pci1723_reset()
and is not used any where else in the driver. Remove it.

Use the register map defines to set the range for each output channel.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 01601aaf

drivers/staging/comedi/drivers/adv_pci1723.c

+1 −3
Original line number Diff line number Diff line
@@ -86,7 +86,6 @@ configures all channels in the same group. 
#define PCI1723_VREF_POS10V		(3 << 0)



struct pci1723_private {

	unsigned char da_range[8];	/* D/A output range for each channel */

	unsigned short ao_data[8];	/* data output buffer */

};
@@ -105,8 +104,7 @@ static int pci1723_reset(struct comedi_device *dev) 
		devpriv->ao_data[i] = 0x8000;

		outw(devpriv->ao_data[i], dev->iobase + PCI1723_AO_REG(i));

		/* set all ranges to +/- 10V */

		devpriv->da_range[i] = 0;

		outw(((devpriv->da_range[i] << 4) | i),

		outw(PCI1723_CTRL_RANGE(0) | PCI1723_CTRL_CHAN(i),

		     PCI1723_CTRL_REG);

	}