Commit 2403d6f1 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Stephen Boyd
Browse files

clk: mediatek: Use %pe to print errors 



If %pe is used to print errors, a string representation of the error
would be printed instead of a number as with %ld. Also, all the sites
printing errors are deriving the error code from a pointer. Using %pe
is more straightforward.

Signed-off-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: default avatarMiles Chen <miles.chen@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220208124034.414635-2-wenst@chromium.org


Reviewed-by: default avatarChun-Jie Chen <chun-jie.chen@mediatek.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 7a688c91

drivers/clk/mediatek/clk-apmixed.c

+1 −1
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ struct clk * __init mtk_clk_register_ref2usb_tx(const char *name, 
	clk = clk_register(NULL, &tx->hw);



	if (IS_ERR(clk)) {

		pr_err("Failed to register clk %s: %ld\n", name, PTR_ERR(clk));

		pr_err("Failed to register clk %s: %pe\n", name, clk);

		kfree(tx);

	}

drivers/clk/mediatek/clk-cpumux.c

+2 −4
Original line number Diff line number Diff line
@@ -87,8 +87,7 @@ int mtk_clk_register_cpumuxes(struct device_node *node, 


	regmap = device_node_to_regmap(node);

	if (IS_ERR(regmap)) {

		pr_err("Cannot find regmap for %pOF: %ld\n", node,

		       PTR_ERR(regmap));

		pr_err("Cannot find regmap for %pOF: %pe\n", node, regmap);

		return PTR_ERR(regmap);

	}
@@ -97,8 +96,7 @@ int mtk_clk_register_cpumuxes(struct device_node *node, 


		clk = mtk_clk_register_cpumux(mux, regmap);

		if (IS_ERR(clk)) {

			pr_err("Failed to register clk %s: %ld\n",

			       mux->name, PTR_ERR(clk));

			pr_err("Failed to register clk %s: %pe\n", mux->name, clk);

			continue;

		}

drivers/clk/mediatek/clk-mtk.c

+6 −12
Original line number Diff line number Diff line
@@ -70,8 +70,7 @@ void mtk_clk_register_fixed_clks(const struct mtk_fixed_clk *clks, 
					      rc->rate);



		if (IS_ERR(clk)) {

			pr_err("Failed to register clk %s: %ld\n",

					rc->name, PTR_ERR(clk));

			pr_err("Failed to register clk %s: %pe\n", rc->name, clk);

			continue;

		}
@@ -97,8 +96,7 @@ void mtk_clk_register_factors(const struct mtk_fixed_factor *clks, 
				CLK_SET_RATE_PARENT, ff->mult, ff->div);



		if (IS_ERR(clk)) {

			pr_err("Failed to register clk %s: %ld\n",

					ff->name, PTR_ERR(clk));

			pr_err("Failed to register clk %s: %pe\n", ff->name, clk);

			continue;

		}
@@ -122,8 +120,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node, 


	regmap = device_node_to_regmap(node);

	if (IS_ERR(regmap)) {

		pr_err("Cannot find regmap for %pOF: %ld\n", node,

				PTR_ERR(regmap));

		pr_err("Cannot find regmap for %pOF: %pe\n", node, regmap);

		return PTR_ERR(regmap);

	}
@@ -141,8 +138,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node, 
				gate->shift, gate->ops, gate->flags, dev);



		if (IS_ERR(clk)) {

			pr_err("Failed to register clk %s: %ld\n",

					gate->name, PTR_ERR(clk));

			pr_err("Failed to register clk %s: %pe\n", gate->name, clk);

			continue;

		}
@@ -264,8 +260,7 @@ void mtk_clk_register_composites(const struct mtk_composite *mcs, 
		clk = mtk_clk_register_composite(mc, base, lock);



		if (IS_ERR(clk)) {

			pr_err("Failed to register clk %s: %ld\n",

					mc->name, PTR_ERR(clk));

			pr_err("Failed to register clk %s: %pe\n", mc->name, clk);

			continue;

		}
@@ -293,8 +288,7 @@ void mtk_clk_register_dividers(const struct mtk_clk_divider *mcds, 
			mcd->div_width, mcd->clk_divider_flags, lock);



		if (IS_ERR(clk)) {

			pr_err("Failed to register clk %s: %ld\n",

				mcd->name, PTR_ERR(clk));

			pr_err("Failed to register clk %s: %pe\n", mcd->name, clk);

			continue;

		}

drivers/clk/mediatek/clk-mux.c

+2 −4
Original line number Diff line number Diff line
@@ -175,8 +175,7 @@ int mtk_clk_register_muxes(const struct mtk_mux *muxes, 


	regmap = device_node_to_regmap(node);

	if (IS_ERR(regmap)) {

		pr_err("Cannot find regmap for %pOF: %ld\n", node,

		       PTR_ERR(regmap));

		pr_err("Cannot find regmap for %pOF: %pe\n", node, regmap);

		return PTR_ERR(regmap);

	}
@@ -187,8 +186,7 @@ int mtk_clk_register_muxes(const struct mtk_mux *muxes, 
			clk = mtk_clk_register_mux(mux, regmap, lock);



			if (IS_ERR(clk)) {

				pr_err("Failed to register clk %s: %ld\n",

				       mux->name, PTR_ERR(clk));

				pr_err("Failed to register clk %s: %pe\n", mux->name, clk);

				continue;

			}

drivers/clk/mediatek/clk-pll.c

+1 −2
Original line number Diff line number Diff line
@@ -378,8 +378,7 @@ void mtk_clk_register_plls(struct device_node *node, 
		clk = mtk_clk_register_pll(pll, base);



		if (IS_ERR(clk)) {

			pr_err("Failed to register clk %s: %ld\n",

					pll->name, PTR_ERR(clk));

			pr_err("Failed to register clk %s: %pe\n", pll->name, clk);

			continue;

		}