Commit 2503a265 authored Sep 12, 2010 by Vasiliy Kulikov Committed by Greg Kroah-Hartman Sep 16, 2010

staging: comedi: fix signess bug



ai_count and ao_counter are unsigned, check for < 0 doesn't make sense.
Cast them to int.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent cae16a17

drivers/staging/comedi/drivers/cb_pcidas64.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3078,7 +3078,7 @@ static void handle_ai_interrupt(struct comedi_device *dev,
		spin_unlock_irqrestore(&dev->spinlock, flags);
		}
		/* if we are have all the data, then quit */
		if ((cmd->stop_src == TRIG_COUNT && priv(dev)->ai_count <= 0) \|\|
		if ((cmd->stop_src == TRIG_COUNT && (int)priv(dev)->ai_count <= 0) \|\|
		(cmd->stop_src == TRIG_EXT && (status & ADC_STOP_BIT))) {
		async->events \|= COMEDI_CB_EOA;
		}

drivers/staging/comedi/drivers/usbdux.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -649,7 +649,7 @@ static void usbduxsub_ao_IsocIrq(struct urb *urb)

		/* normal operation: executing a command in this subdevice */
		this_usbduxsub->ao_counter--;
		if (this_usbduxsub->ao_counter <= 0) {
		if ((int)this_usbduxsub->ao_counter <= 0) {
		/* timer zero */
		this_usbduxsub->ao_counter = this_usbduxsub->ao_timer;