Commit 275e64de authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

device create: dca: convert device_create to device_create_drvdata 



device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 6143b599

drivers/dca/dca-sysfs.c

+5 −3
Original line number Original line Diff line number Diff line
@@ -14,7 +14,8 @@ int dca_sysfs_add_req(struct dca_provider *dca, struct device *dev, int slot) 
{

{

	struct device *cd;

	struct device *cd;





	cd = device_create(dca_class, dca->cd, MKDEV(0, slot + 1),

	cd = device_create_drvdata(dca_class, dca->cd,

				   MKDEV(0, slot + 1), NULL,

				   "requester%d", slot);

				   "requester%d", slot);

	if (IS_ERR(cd))

	if (IS_ERR(cd))

		return PTR_ERR(cd);

		return PTR_ERR(cd);
@@ -46,7 +47,8 @@ int dca_sysfs_add_provider(struct dca_provider *dca, struct device *dev) 
		return err;

		return err;

	}

	}





	cd = device_create(dca_class, dev, MKDEV(0, 0), "dca%d", dca->id);

	cd = device_create_drvdata(dca_class, dev, MKDEV(0, 0), NULL,

				   "dca%d", dca->id);

	if (IS_ERR(cd)) {

	if (IS_ERR(cd)) {

		spin_lock(&dca_idr_lock);

		spin_lock(&dca_idr_lock);

		idr_remove(&dca_idr, dca->id);

		idr_remove(&dca_idr, dca->id);