Commit 279cf174 authored by Samuel Ortiz's avatar Samuel Ortiz Committed by John W. Linville
Browse files

NFC: No need to apply twice the modulo op to LLCP's recv_n 



recv_n is set properly when receiving an HDLC frame.

Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 4be646ec

net/nfc/llcp/commands.c

+1 −1
Original line number Diff line number Diff line
@@ -522,7 +522,7 @@ int nfc_llcp_send_rr(struct nfc_llcp_sock *sock) 


	skb_put(skb, LLCP_SEQUENCE_SIZE);



	skb->data[2] = sock->recv_n % 16;

	skb->data[2] = sock->recv_n;



	skb_queue_head(&local->tx_queue, skb);

net/nfc/llcp/llcp.c

+1 −1
Original line number Diff line number Diff line
@@ -428,7 +428,7 @@ static u8 nfc_llcp_nr(struct sk_buff *pdu) 


static void nfc_llcp_set_nrns(struct nfc_llcp_sock *sock, struct sk_buff *pdu)

{

	pdu->data[2] = (sock->send_n << 4) | (sock->recv_n % 16);

	pdu->data[2] = (sock->send_n << 4) | (sock->recv_n);

	sock->send_n = (sock->send_n + 1) % 16;

	sock->recv_ack_n = (sock->recv_n - 1) % 16;

}