Commit 2877f245 authored by Juston Li's avatar Juston Li Committed by Greg Kroah-Hartman
Browse files

staging/lustre: use __noreturn for lbug_with_loc 



fixes sparse error:
drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c:149:6: error:
symbol 'lbug_with_loc'redeclared with different type (originally declared at
drivers/staging/lustre/lustre/libcfs/linux/../../../include/linux/libcfs/libcfs_private.h:82)
- different modifiers

Use the __noreturn macro instead of __attribute__((noreturn))
The macro is exactly that but its usage seems more common and
it is bit more readable.

Signed-off-by: default avatarJuston Li <juston.h.li@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 59cfb96f

drivers/staging/lustre/include/linux/libcfs/libcfs_private.h

+1 −1
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ do { \ 


#define KLASSERT(e) LASSERT(e)



void lbug_with_loc(struct libcfs_debug_msg_data *)__attribute__((noreturn));

void __noreturn lbug_with_loc(struct libcfs_debug_msg_data *);



#define LBUG()							  \

do {								    \

drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c

+1 −1
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ void libcfs_run_lbug_upcall(struct libcfs_debug_msg_data *msgdata) 
}



/* coverity[+kill] */

void lbug_with_loc(struct libcfs_debug_msg_data *msgdata)

void __noreturn lbug_with_loc(struct libcfs_debug_msg_data *msgdata)

{

	libcfs_catastrophe = 1;

	libcfs_debug_msg(msgdata, "LBUG\n");