Commit 28f3fb1c authored by Paul Cercueil's avatar Paul Cercueil Committed by Andi Shyti
Browse files

i2c: hix5hd2: Remove #ifdef guards for PM related functions 



Use the new PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Note that this driver should probably use the
DEFINE_RUNTIME_DEV_PM_OPS() macro, which would allow the devices to be
runtime-suspended on system suspend.

Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20230722115046.27323-8-paul@crapouillou.net


Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent 375b26c9

drivers/i2c/busses/i2c-hix5hd2.c

+4 −6
Original line number Diff line number Diff line
@@ -475,7 +475,6 @@ static void hix5hd2_i2c_remove(struct platform_device *pdev) 
	pm_runtime_set_suspended(priv->dev);

}



#ifdef CONFIG_PM

static int hix5hd2_i2c_runtime_suspend(struct device *dev)

{

	struct hix5hd2_i2c_priv *priv = dev_get_drvdata(dev);
@@ -494,10 +493,9 @@ static int hix5hd2_i2c_runtime_resume(struct device *dev) 


	return 0;

}

#endif



static const struct dev_pm_ops hix5hd2_i2c_pm_ops = {

	SET_RUNTIME_PM_OPS(hix5hd2_i2c_runtime_suspend,

	RUNTIME_PM_OPS(hix5hd2_i2c_runtime_suspend,

		       hix5hd2_i2c_runtime_resume,

		       NULL)

};
@@ -513,7 +511,7 @@ static struct platform_driver hix5hd2_i2c_driver = { 
	.remove_new	= hix5hd2_i2c_remove,

	.driver		= {

		.name	= "hix5hd2-i2c",

		.pm	= &hix5hd2_i2c_pm_ops,

		.pm	= pm_ptr(&hix5hd2_i2c_pm_ops),

		.of_match_table = hix5hd2_i2c_match,

	},

};