Commit 29626f3c authored by Michael Straube's avatar Michael Straube Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: convert rtw_free_stainfo() to void 



The function rtw_free_stainfo() returns always _SUCCESS and none of
its callers uses the return value. We can safely make the function
void. Yet another tiny step towards getting rid of _FAIL / _SUCCESS.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: default avatarMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20221101191458.8619-3-straube.linux@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1a6d6470

drivers/staging/r8188eu/core/rtw_sta_mgt.c

+2 −6
Original line number Diff line number Diff line
@@ -242,7 +242,7 @@ struct sta_info *rtw_alloc_stainfo(struct sta_priv *pstapriv, u8 *hwaddr) 
}



/*  using pstapriv->sta_hash_lock to protect */

u32	rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta)

void rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta)

{

	int i;

	struct __queue *pfree_sta_queue;
@@ -252,7 +252,7 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta) 
	struct	sta_priv *pstapriv = &padapter->stapriv;



	if (!psta)

		goto exit;

		return;



	pfree_sta_queue = &pstapriv->free_sta_queue;
@@ -356,10 +356,6 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta) 
	spin_lock_bh(&pfree_sta_queue->lock);

	list_add_tail(&psta->list, get_list_head(pfree_sta_queue));

	spin_unlock_bh(&pfree_sta_queue->lock);



exit:



	return _SUCCESS;

}



/*  free all stainfo which in sta_hash[all] */

drivers/staging/r8188eu/include/sta_info.h

+1 −1
Original line number Diff line number Diff line
@@ -303,7 +303,7 @@ int rtw_stainfo_offset(struct sta_priv *stapriv, struct sta_info *sta); 
struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int off);



struct sta_info *rtw_alloc_stainfo(struct sta_priv *stapriv, u8 *hwaddr);

u32	rtw_free_stainfo(struct adapter *adapt, struct sta_info *psta);

void rtw_free_stainfo(struct adapter *adapt, struct sta_info *psta);

void rtw_free_all_stainfo(struct adapter *adapt);

struct sta_info *rtw_get_stainfo(struct sta_priv *stapriv, u8 *hwaddr);

u32 rtw_init_bcmc_stainfo(struct adapter *adapt);