Commit 299dd6eb authored Mar 08, 2022 by Jakob Koschel Committed by Greg Kroah-Hartman Mar 15, 2022

usb: gadget: mv_u3d: remove usage of list iterator past the loop body

If the list representing the request queue does not contain the expected
request, the value of the list_for_each_entry() iterator will not point
to a valid structure. To avoid type confusion in such case, the list
iterator scope will be limited to the list_for_each_entry() loop.

In preparation to limiting scope of the list iterator to the list traversal
loop, use a dedicated pointer to point to the found request object [1].

Link: https://lore.kernel.org/all/YhdfEIwI4EdtHdym@kroah.com/

Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220308171818.384491-10-jakobkoschel@gmail.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4a2a73bf

drivers/usb/gadget/udc/mv_u3d_core.c

+7 −5

Original line number	Diff line number	Diff line
		@@ -844,7 +844,7 @@ mv_u3d_ep_queue(struct usb_ep _ep, struct usb_request _req, gfp_t gfp_flags)
		static int mv_u3d_ep_dequeue(struct usb_ep _ep, struct usb_request _req)
		{
		struct mv_u3d_ep *ep;
		struct mv_u3d_req *req;
		struct mv_u3d_req req = NULL, iter;
		struct mv_u3d *u3d;
		struct mv_u3d_ep_context *ep_context;
		struct mv_u3d_req *next_req;
		@@ -861,11 +861,13 @@ static int mv_u3d_ep_dequeue(struct usb_ep _ep, struct usb_request _req)
		spin_lock_irqsave(&ep->u3d->lock, flags);

		/* make sure it's actually queued on this endpoint */
		list_for_each_entry(req, &ep->queue, queue) {
		if (&req->req == _req)
		list_for_each_entry(iter, &ep->queue, queue) {
		if (&iter->req != _req)
		continue;
		req = iter;
		break;
		}
		if (&req->req != _req) {
		if (!req) {
		ret = -EINVAL;
		goto out;
		}