Commit 29dbb9bc authored by Stefan Binding's avatar Stefan Binding Committed by Takashi Iwai
Browse files

ALSA: hda/cs8409: Reduce HS pops/clicks for Cyborg 



Enable HSBIAS_SENSE_EN for Cyborg during jack detect to reduce
pops and clicks.
Do not enable this for Warlock/Bullseye, as it causes ESD issues.

Signed-off-by: default avatarStefan Binding <sbinding@opensource.cirrus.com>
Signed-off-by: default avatarVitaly Rodionov <vitalyr@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210811185654.6837-6-vitalyr@opensource.cirrus.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent cab82a22

sound/pci/hda/patch_cs8409.c

+8 −2
Original line number Diff line number Diff line
@@ -390,8 +390,14 @@ static void cs8409_cs42l42_enable_jack_detect(struct hda_codec *codec) 


	mutex_lock(&spec->cs8409_i2c_mux);



	/* Set TIP_SENSE_EN for analog front-end of tip sense. */

	/* Set TIP_SENSE_EN for analog front-end of tip sense.

	 * Additionally set HSBIAS_SENSE_EN for some variants.

	 */

	if (codec->fixup_id == CS8409_WARLOCK || codec->fixup_id == CS8409_BULLSEYE)

		cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b70, 0x0020, 1);

	else

		cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b70, 0x00a0, 1);



	/* Clear WAKE# */

	cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b71, 0x0001, 1);

	/* Wait ~2.5ms */