Commit 2a50e8d7 authored by Tomi Valkeinen's avatar Tomi Valkeinen Committed by Mauro Carvalho Chehab
Browse files

media: ti: cal: fix useless variable init 



'ret' is initialized needlessly in cal_legacy_try_fmt_vid_cap(). We can
also move the variable to the for block, which is the only place where
it is used.

Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 3028fb90

drivers/media/platform/ti/cal/cal-video.c

+3 −2
Original line number Diff line number Diff line
@@ -191,7 +191,7 @@ static int cal_legacy_try_fmt_vid_cap(struct file *file, void *priv, 
	struct cal_ctx *ctx = video_drvdata(file);

	const struct cal_format_info *fmtinfo;

	struct v4l2_subdev_frame_size_enum fse;

	int ret, found;

	int found;



	fmtinfo = find_format_by_pix(ctx, f->fmt.pix.pixelformat);

	if (!fmtinfo) {
@@ -206,12 +206,13 @@ static int cal_legacy_try_fmt_vid_cap(struct file *file, void *priv, 
	f->fmt.pix.field = ctx->v_fmt.fmt.pix.field;



	/* check for/find a valid width/height */

	ret = 0;

	found = false;

	fse.pad = 0;

	fse.code = fmtinfo->code;

	fse.which = V4L2_SUBDEV_FORMAT_ACTIVE;

	for (fse.index = 0; ; fse.index++) {

		int ret;



		ret = v4l2_subdev_call(ctx->phy->source, pad, enum_frame_size,

				       NULL, &fse);

		if (ret)