Commit 2a534e1d authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: bail out of ext4_xattr_ibody_get() fails for any reason 



In ext4_update_inline_data(), if ext4_xattr_ibody_get() fails for any
reason, it's best if we just fail as opposed to stumbling on,
especially if the failure is EFSCORRUPTED.

Cc: stable@kernel.org
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 2220eaf9

fs/ext4/inline.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -360,7 +360,7 @@ static int ext4_update_inline_data(handle_t *handle, struct inode *inode, 




	error = ext4_xattr_ibody_get(inode, i.name_index, i.name,

	error = ext4_xattr_ibody_get(inode, i.name_index, i.name,

				     value, len);

				     value, len);

	if (error == -ENODATA)

	if (error < 0)

		goto out;

		goto out;





	BUFFER_TRACE(is.iloc.bh, "get_write_access");

	BUFFER_TRACE(is.iloc.bh, "get_write_access");