Commit 2a807341 authored by Bas Nieuwenhuizen's avatar Bas Nieuwenhuizen Committed by Alex Deucher
Browse files

drm/amdgpu/display: Remove t_srx_delay_us. 



Unused. Convert the divisions into asserts on the divisor, to
debug why it is zero. The divide by zero is suspected of causing
kernel panics.

While I have no idea where the zero is coming from I think this
patch is a positive either way.

Cc: stable@vger.kernel.org
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 25f1488b

drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c

+0 −1
Original line number Diff line number Diff line
@@ -503,7 +503,6 @@ static void dcn_bw_calc_rq_dlg_ttu( 
	//input[in_idx].dout.output_standard;



	/*todo: soc->sr_enter_plus_exit_time??*/

	dlg_sys_param->t_srx_delay_us = dc->dcn_ip->dcfclk_cstate_latency / v->dcf_clk_deep_sleep;



	dml1_rq_dlg_get_rq_params(dml, rq_param, &input->pipe.src);

	dml1_extract_rq_regs(dml, rq_regs, rq_param);

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c

+0 −2
Original line number Diff line number Diff line
@@ -1576,8 +1576,6 @@ void dml20_rq_dlg_get_dlg_reg(struct display_mode_lib *mode_lib, 
	dlg_sys_param.total_flip_bytes = get_total_immediate_flip_bytes(mode_lib,

			e2e_pipe_param,

			num_pipes);

	dlg_sys_param.t_srx_delay_us = mode_lib->ip.dcfclk_cstate_latency

			/ dlg_sys_param.deepsleep_dcfclk_mhz; // TODO: Deprecated



	print__dlg_sys_params_st(mode_lib, &dlg_sys_param);

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c

+0 −2
Original line number Diff line number Diff line
@@ -1577,8 +1577,6 @@ void dml20v2_rq_dlg_get_dlg_reg(struct display_mode_lib *mode_lib, 
	dlg_sys_param.total_flip_bytes = get_total_immediate_flip_bytes(mode_lib,

			e2e_pipe_param,

			num_pipes);

	dlg_sys_param.t_srx_delay_us = mode_lib->ip.dcfclk_cstate_latency

			/ dlg_sys_param.deepsleep_dcfclk_mhz; // TODO: Deprecated



	print__dlg_sys_params_st(mode_lib, &dlg_sys_param);

drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c

+0 −2
Original line number Diff line number Diff line
@@ -1688,8 +1688,6 @@ void dml21_rq_dlg_get_dlg_reg( 
			mode_lib,

			e2e_pipe_param,

			num_pipes);

	dlg_sys_param.t_srx_delay_us = mode_lib->ip.dcfclk_cstate_latency

			/ dlg_sys_param.deepsleep_dcfclk_mhz; // TODO: Deprecated



	print__dlg_sys_params_st(mode_lib, &dlg_sys_param);

drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c

+0 −2
Original line number Diff line number Diff line
@@ -1858,8 +1858,6 @@ void dml30_rq_dlg_get_dlg_reg(struct display_mode_lib *mode_lib, 
	dlg_sys_param.total_flip_bytes = get_total_immediate_flip_bytes(mode_lib,

		e2e_pipe_param,

		num_pipes);

	dlg_sys_param.t_srx_delay_us = mode_lib->ip.dcfclk_cstate_latency

		/ dlg_sys_param.deepsleep_dcfclk_mhz; // TODO: Deprecated



	print__dlg_sys_params_st(mode_lib, &dlg_sys_param);