Commit 2ab52083 authored by Anton Blanchard's avatar Anton Blanchard Committed by Ingo Molnar
Browse files

perf top: Move skip symbols to an array 



Move the list of symbols we skip into an array, making it
easier to add new ones.

Signed-off-by: default avatarAnton Blanchard <anton@samba.org>
Cc: a.p.zijlstra@chello.nl
Cc: paulus@samba.org
LKML-Reference: <20090630230140.904782938@samba.org>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 6717534d

tools/perf/builtin-top.c

+17 −7
Original line number Diff line number Diff line
@@ -286,11 +286,22 @@ static void *display_thread(void *arg) 
	return NULL;

}



/* Tag samples to be skipped. */

char *skip_symbols[] = {

	"default_idle",

	"cpu_idle",

	"enter_idle",

	"exit_idle",

	"mwait_idle",

	NULL

};



static int symbol_filter(struct dso *self, struct symbol *sym)

{

	static int filter_match;

	struct sym_entry *syme;

	const char *name = sym->name;

	int i;



	if (!strcmp(name, "_text") ||

	    !strcmp(name, "_etext") ||
@@ -302,13 +313,12 @@ static int symbol_filter(struct dso *self, struct symbol *sym) 
		return 1;



	syme = dso__sym_priv(self, sym);

	/* Tag samples to be skipped. */

	if (!strcmp("default_idle", name) ||

	    !strcmp("cpu_idle", name) ||

	    !strcmp("enter_idle", name) ||

	    !strcmp("exit_idle", name) ||

	    !strcmp("mwait_idle", name))

	for (i = 0; skip_symbols[i]; i++) {

		if (!strcmp(skip_symbols[i], name)) {

			syme->skip = 1;

			break;

		}

	}



	if (filter_match == 1) {

		filter_end = sym->start;