Commit 2af0bf34 authored by Yang Li's avatar Yang Li Committed by Martin K. Petersen
Browse files

scsi: 3w-sas: Remove unneeded variable 'retval' 

Fix the following coccicheck warning:

 ./drivers/scsi/3w-sas.c:866:5-11: Unneeded variable: "retval". Return "1"
on line 898

Link: https://lore.kernel.org/r/1615272064-42109-1-git-send-email-yang.lee@linux.alibaba.com


Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 59f90f5e

drivers/scsi/3w-sas.c

+1 −2
Original line number Diff line number Diff line
@@ -860,7 +860,6 @@ static int twl_fill_sense(TW_Device_Extension *tw_dev, int i, int request_id, in 
	TW_Command_Full *full_command_packet;

	unsigned short error;

	char *error_str;

	int retval = 1;



	header = tw_dev->sense_buffer_virt[i];

	full_command_packet = tw_dev->command_packet_virt[request_id];
@@ -892,7 +891,7 @@ static int twl_fill_sense(TW_Device_Extension *tw_dev, int i, int request_id, in 
		goto out;

	}

out:

	return retval;

	return 1;

} /* End twl_fill_sense() */



/* This function will free up device extension resources */