Commit 2e13ab01 authored by Jithu Joseph's avatar Jithu Joseph Committed by Borislav Petkov
Browse files

x86/microcode/intel: Use appropriate type in microcode_sanity_check() 



The data type of the @print_err parameter used by microcode_sanity_check()
is int. In preparation for exporting this function to be used by
the IFS driver convert it to a more appropriate bool type for readability.

No functional change intended.

Suggested-by: default avatarTony Luck <tony.luck@intel.com>
Signed-off-by: default avatarJithu Joseph <jithu.joseph@intel.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Reviewed-by: default avatarTony Luck <tony.luck@intel.com>
Reviewed-by: default avatarAshok Raj <ashok.raj@intel.com>
Reviewed-by: default avatarSohil Mehta <sohil.mehta@intel.com>
Link: https://lore.kernel.org/r/20221117035935.4136738-7-jithu.joseph@intel.com
parent 716f3802

arch/x86/kernel/cpu/microcode/intel.c

+3 −3
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ static void save_microcode_patch(struct ucode_cpu_info *uci, void *data, unsigne 
		intel_ucode_patch = p->data;

}



static int microcode_sanity_check(void *mc, int print_err)

static int microcode_sanity_check(void *mc, bool print_err)

{

	unsigned long total_size, data_size, ext_table_size;

	struct microcode_header_intel *mc_header = mc;
@@ -253,7 +253,7 @@ scan_microcode(void *data, size_t size, struct ucode_cpu_info *uci, bool save) 
		mc_size = get_totalsize(mc_header);

		if (!mc_size ||

		    mc_size > size ||

		    microcode_sanity_check(data, 0) < 0)

		    microcode_sanity_check(data, false) < 0)

			break;



		size -= mc_size;
@@ -792,7 +792,7 @@ static enum ucode_state generic_load_microcode(int cpu, struct iov_iter *iter) 
		memcpy(mc, &mc_header, sizeof(mc_header));

		data = mc + sizeof(mc_header);

		if (!copy_from_iter_full(data, data_size, iter) ||

		    microcode_sanity_check(mc, 1) < 0) {

		    microcode_sanity_check(mc, true) < 0) {

			break;

		}