Commit 2f0d67bf authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Stephen Boyd
Browse files

clk: tegra: clk-tegra124-dfll-fcpu: don't use devm functions for regulator 



The purpose of the device-managed functions is to bind the life-time of an
object to that of a parent device object.

This is not the case for the 'vdd-cpu' regulator in this driver. A
reference is obtained via devm_regulator_get() and immediately released
with devm_regulator_put().

In this case, the usage of devm_ functions is slightly excessive, as the
un-managed versions of these functions is a little cleaner (and slightly
more economical in terms of allocation).

This change converts the devm_regulator_{get,put}() to
regulator_{get,put}() in the get_alignment_from_regulator() function of
this driver.

Signed-off-by: default avatarAlexandru Ardelean <aardelean@deviqon.com>
Link: https://lore.kernel.org/r/20210624084737.42336-1-aardelean@deviqon.com


Reviewed-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 3f4e557d

drivers/clk/tegra/clk-tegra124-dfll-fcpu.c

+2 −2
Original line number Diff line number Diff line
@@ -537,7 +537,7 @@ static void get_alignment_from_dt(struct device *dev, 
static int get_alignment_from_regulator(struct device *dev,

					 struct rail_alignment *align)

{

	struct regulator *reg = devm_regulator_get(dev, "vdd-cpu");

	struct regulator *reg = regulator_get(dev, "vdd-cpu");



	if (IS_ERR(reg))

		return PTR_ERR(reg);
@@ -545,7 +545,7 @@ static int get_alignment_from_regulator(struct device *dev, 
	align->offset_uv = regulator_list_voltage(reg, 0);

	align->step_uv = regulator_get_linear_step(reg);



	devm_regulator_put(reg);

	regulator_put(reg);



	return 0;

}