Commit 3027d37d authored by Vihas Makwana's avatar Vihas Makwana Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: mark _rtw_free_sta_priv as void 



_rtw_free_sta_priv() always returns _SUCCESS and it's return value
isn't checked either.
So it makes sense to mark it as void instead of u32.

Signed-off-by: default avatarVihas Makwana <makvihas@gmail.com>
Link: https://lore.kernel.org/r/20220213173424.39935-1-makvihas@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 56f1124a

drivers/staging/r8188eu/core/rtw_sta_mgt.c

+1 −3
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ inline struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int 
	return (struct sta_info *)(stapriv->pstainfo_buf + offset * sizeof(struct sta_info));

}



u32	_rtw_free_sta_priv(struct	sta_priv *pstapriv)

void _rtw_free_sta_priv(struct	sta_priv *pstapriv)

{

	struct list_head *phead, *plist;

	struct sta_info *psta = NULL;
@@ -147,8 +147,6 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv) 


		vfree(pstapriv->pallocated_stainfo_buf);

	}



	return _SUCCESS;

}



struct	sta_info *rtw_alloc_stainfo(struct sta_priv *pstapriv, u8 *hwaddr)

drivers/staging/r8188eu/include/sta_info.h

+1 −1
Original line number Diff line number Diff line
@@ -344,7 +344,7 @@ static inline u32 wifi_mac_hash(u8 *mac) 
}



extern u32	_rtw_init_sta_priv(struct sta_priv *pstapriv);

extern u32	_rtw_free_sta_priv(struct sta_priv *pstapriv);

extern void _rtw_free_sta_priv(struct sta_priv *pstapriv);



#define stainfo_offset_valid(offset) (offset < NUM_STA && offset >= 0)

int rtw_stainfo_offset(struct sta_priv *stapriv, struct sta_info *sta);