Commit 30492c12 authored by Krzysztof Wilczyński's avatar Krzysztof Wilczyński Committed by Bjorn Helgaas
Browse files

PCI: artpec6: Remove local code block from switch statement 



The switch statement in the artpec6_pcie_probe() has a local code block
where "val" is defined and immediately used by the artpec6_pcie_readl().

This extra code block adds brackets at the same indentation level as the
switch statement itself which can hinder readability of the code.

Move the "val" declaration to the top of the function and remove
the extra code block from the switch statement.

Suggested-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20210701204401.1636562-2-kw@linux.com


Signed-off-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarJesper Nilsson <jesper.nilsson@axis.com>
parent ee6f8568

drivers/pci/controller/dwc/pcie-artpec6.c

+2 −4
Original line number Diff line number Diff line
@@ -384,6 +384,7 @@ static int artpec6_pcie_probe(struct platform_device *pdev) 
	const struct artpec_pcie_of_data *data;

	enum artpec_pcie_variants variant;

	enum dw_pcie_device_mode mode;

	u32 val;



	match = of_match_device(artpec6_pcie_of_match, dev);

	if (!match)
@@ -432,9 +433,7 @@ static int artpec6_pcie_probe(struct platform_device *pdev) 
		if (ret < 0)

			return ret;

		break;

	case DW_PCIE_EP_TYPE: {

		u32 val;



	case DW_PCIE_EP_TYPE:

		if (!IS_ENABLED(CONFIG_PCIE_ARTPEC6_EP))

			return -ENODEV;
@@ -445,7 +444,6 @@ static int artpec6_pcie_probe(struct platform_device *pdev) 
		pci->ep.ops = &pcie_ep_ops;



		return dw_pcie_ep_init(&pci->ep);

	}

	default:

		dev_err(dev, "INVALID device type %d\n", artpec6_pcie->mode);

	}