Commit 31218df7 authored by Yizhuo's avatar Yizhuo Committed by Mauro Carvalho Chehab
Browse files

media: media/pci/ivtv: Variable vbi.type could be uninitialized if macro... 


media: media/pci/ivtv: Variable vbi.type could be uninitialized if macro v4l2_subdev_call set __result an error code

Inside function compress_sliced_buf(), variable vbi.type is
uninitialized if macro v4l2_subdev_call set __result an
error code. However, vbi.type is used in the if statement
without any check, which is potentially unsafe.

Signed-off-by: default avatarYizhuo <yzhai003@ucr.edu>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 6bf05f75

drivers/media/pci/ivtv/ivtv-vbi.c

+1 −1
Original line number Diff line number Diff line
@@ -325,7 +325,7 @@ static u32 compress_raw_buf(struct ivtv *itv, u8 *buf, u32 size) 
static u32 compress_sliced_buf(struct ivtv *itv, u32 line, u8 *buf, u32 size, u8 sav)

{

	u32 line_size = itv->vbi.sliced_decoder_line_size;

	struct v4l2_decode_vbi_line vbi;

	struct v4l2_decode_vbi_line vbi = {};

	int i;

	unsigned lines = 0;