Commit 3136dc60 authored by Vihas Makwana's avatar Vihas Makwana Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: drop redundant check in _rtw_free_mlme_priv 



There's a NULL check on pmlmepriv in rtw_mlme.c:112 which makes no sense
as rtw_free_mlme_priv_ie_data() dereferences it unconditionally and it
would have already crashed at this point.
Remove this redundant check.

Signed-off-by: default avatarVihas Makwana <makvihas@gmail.com>
Link: https://lore.kernel.org/r/20220427165748.10584-1-makvihas@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 921f9c58

drivers/staging/r8188eu/core/rtw_mlme.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -248,8 +248,6 @@ int rtw_init_mlme_priv(struct adapter *padapter)/* struct mlme_priv *pmlmepriv) 
void rtw_free_mlme_priv(struct mlme_priv *pmlmepriv)

void rtw_free_mlme_priv(struct mlme_priv *pmlmepriv)

{

{

	rtw_free_mlme_priv_ie_data(pmlmepriv);

	rtw_free_mlme_priv_ie_data(pmlmepriv);



	if (pmlmepriv)

	vfree(pmlmepriv->free_bss_buf);

	vfree(pmlmepriv->free_bss_buf);

}

}