Commit 3239e7bb authored by Jiong Wang's avatar Jiong Wang Committed by Daniel Borkmann
Browse files

nfp: bpf: correct the encoding for No-Dest immed 



When immed is used with No-Dest, the emitter should use reg.dst instead of
reg.areg for the destination, using the latter will actually encode
register zero.

Signed-off-by: default avatarJiong Wang <jiong.wang@netronome.com>
Reviewed-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 08859f15

drivers/net/ethernet/netronome/nfp/bpf/jit.c

+5 −3
Original line number Diff line number Diff line
@@ -224,9 +224,11 @@ emit_immed(struct nfp_prog *nfp_prog, swreg dst, u16 imm, 
		return;

	}



	__emit_immed(nfp_prog, reg.areg, reg.breg, imm >> 8, width,

		     invert, shift, reg.wr_both,

		     reg.dst_lmextn, reg.src_lmextn);

	/* Use reg.dst when destination is No-Dest. */

	__emit_immed(nfp_prog,

		     swreg_type(dst) == NN_REG_NONE ? reg.dst : reg.areg,

		     reg.breg, imm >> 8, width, invert, shift,

		     reg.wr_both, reg.dst_lmextn, reg.src_lmextn);

}



static void