Commit 32418cfe authored by Dave Jones's avatar Dave Jones Committed by David S. Miller
Browse files

Remove noisy printks from llcp_sock_connect



Validation of userspace input shouldn't trigger dmesg spamming.

Signed-off-by: default avatarDave Jones <davej@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 19d4e663
Loading
Loading
Loading
Loading
+2 −6
Original line number Original line Diff line number Diff line
@@ -497,15 +497,11 @@ static int llcp_sock_connect(struct socket *sock, struct sockaddr *_addr,
	pr_debug("sock %p sk %p flags 0x%x\n", sock, sk, flags);
	pr_debug("sock %p sk %p flags 0x%x\n", sock, sk, flags);


	if (!addr || len < sizeof(struct sockaddr_nfc) ||
	if (!addr || len < sizeof(struct sockaddr_nfc) ||
	    addr->sa_family != AF_NFC) {
	    addr->sa_family != AF_NFC)
		pr_err("Invalid socket\n");
		return -EINVAL;
		return -EINVAL;
	}


	if (addr->service_name_len == 0 && addr->dsap == 0) {
	if (addr->service_name_len == 0 && addr->dsap == 0)
		pr_err("Missing service name or dsap\n");
		return -EINVAL;
		return -EINVAL;
	}


	pr_debug("addr dev_idx=%u target_idx=%u protocol=%u\n", addr->dev_idx,
	pr_debug("addr dev_idx=%u target_idx=%u protocol=%u\n", addr->dev_idx,
		 addr->target_idx, addr->nfc_protocol);
		 addr->target_idx, addr->nfc_protocol);