Unverified Commit 3327d721 authored by Wang Yufen's avatar Wang Yufen Committed by Mark Brown
Browse files

ASoC: mediatek: mt8173-rt5650-rt5514: fix refcount leak in mt8173_rt5650_rt5514_dev_probe() 



The node returned by of_parse_phandle() with refcount incremented,
of_node_put() needs be called when finish using it. So add it in the
error path in mt8173_rt5650_rt5514_dev_probe().

Fixes: 0d1d7a66 ("ASoC: mediatek: Refine mt8173 driver and change config option")
Signed-off-by: default avatarWang Yufen <wangyufen@huawei.com>
Link: https://lore.kernel.org/r/1670234664-24246-1-git-send-email-wangyufen@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8e378ea1

sound/soc/mediatek/mt8173/mt8173-rt5650-rt5514.c

+5 −2
Original line number Diff line number Diff line
@@ -200,14 +200,16 @@ static int mt8173_rt5650_rt5514_dev_probe(struct platform_device *pdev) 
	if (!mt8173_rt5650_rt5514_dais[DAI_LINK_CODEC_I2S].codecs[0].of_node) {

		dev_err(&pdev->dev,

			"Property 'audio-codec' missing or invalid\n");

		return -EINVAL;

		ret = -EINVAL;

		goto out;

	}

	mt8173_rt5650_rt5514_dais[DAI_LINK_CODEC_I2S].codecs[1].of_node =

		of_parse_phandle(pdev->dev.of_node, "mediatek,audio-codec", 1);

	if (!mt8173_rt5650_rt5514_dais[DAI_LINK_CODEC_I2S].codecs[1].of_node) {

		dev_err(&pdev->dev,

			"Property 'audio-codec' missing or invalid\n");

		return -EINVAL;

		ret = -EINVAL;

		goto out;

	}

	mt8173_rt5650_rt5514_codec_conf[0].dlc.of_node =

		mt8173_rt5650_rt5514_dais[DAI_LINK_CODEC_I2S].codecs[1].of_node;
@@ -216,6 +218,7 @@ static int mt8173_rt5650_rt5514_dev_probe(struct platform_device *pdev) 


	ret = devm_snd_soc_register_card(&pdev->dev, card);



out:

	of_node_put(platform_node);

	return ret;

}