Commit 334ef6ab authored by Fabio Aiuto's avatar Fabio Aiuto Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove all commented out DBG_8192C logs 



remove all commented out DBG_8192C logs.

Macro DBG_8192C belongs to a family of verbose
private tracing macros.

The default behaviour is _do nothing_, to activate
it one should define DEBUG symbol by hand.

So just remove it

Signed-off-by: default avatarFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/d954fbde0ae689cd053a57f57f954f14b5d013cb.1618064274.git.fabioaiuto83@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dcc48e08

drivers/staging/rtl8723bs/core/rtw_ieee80211.c

+0 −1
Original line number Diff line number Diff line
@@ -670,7 +670,6 @@ u8 rtw_is_wps_ie(u8 *ie_ptr, uint *wps_ielen) 
	eid = ie_ptr[0];



	if ((eid == WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&ie_ptr[2], wps_oui, 4))) {

		/* DBG_8192C("==> found WPS_IE.....\n"); */

		*wps_ielen = ie_ptr[1]+2;

		match = true;

	}

drivers/staging/rtl8723bs/core/rtw_wlan_util.c

+0 −3
Original line number Diff line number Diff line
@@ -504,14 +504,11 @@ void read_cam(struct adapter *padapter, u8 entry, u8 *get_key) 


	addr = entry << 3;



	/* DBG_8192C("********* DUMP CAM Entry_#%02d***************\n", entry); */

	for (j = 0; j < 6; j++) {

		cmd = _ReadCAM(padapter, addr+j);

		/* DBG_8192C("offset:0x%02x => 0x%08x\n", addr+j, cmd); */

		if (j > 1) /* get key from cam */

			memcpy(get_key+(j-2)*4, &cmd, 4);

	}

	/* DBG_8192C("*********************************\n"); */

}



void _write_cam(struct adapter *padapter, u8 entry, u16 ctrl, u8 *mac, u8 *key)

drivers/staging/rtl8723bs/hal/odm.c

+0 −1
Original line number Diff line number Diff line
@@ -635,7 +635,6 @@ static void FindMinimumRSSI(struct adapter *padapter) 
	} else

		pdmpriv->MinUndecoratedPWDBForDM = pdmpriv->EntryMinUndecoratedSmoothedPWDB;



	/* DBG_8192C("%s =>MinUndecoratedPWDBForDM(%d)\n", __func__, pdmpriv->MinUndecoratedPWDBForDM); */

	/* ODM_RT_TRACE(pDM_Odm, COMP_DIG, DBG_LOUD, ("MinUndecoratedPWDBForDM =%d\n", pHalData->MinUndecoratedPWDBForDM)); */

}

drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c

+0 −12
Original line number Diff line number Diff line
@@ -24,8 +24,6 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num) 


	u8 valid;



	/* DBG_8192C(" _is_fw_read_cmd_down , reg_1cc(%x), msg_box(%d)...\n", rtw_read8(padapter, REG_HMETFR), msgbox_num); */



	do {

		valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num);

		if (0 == valid) {
@@ -77,8 +75,6 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd 
		h2c_box_num = pHalData->LastHMEBoxNum;



		if (!_is_fw_read_cmd_down(padapter, h2c_box_num)) {

			/* DBG_8192C(" 0x1c0: 0x%8x\n", rtw_read32(padapter, 0x1c0)); */

			/* DBG_8192C(" 0x1c4: 0x%8x\n", rtw_read32(padapter, 0x1c4)); */

			goto exit;

		}
@@ -99,9 +95,6 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd 
		msgbox_addr = REG_HMEBOX_0 + (h2c_box_num*MESSAGE_BOX_SIZE);

		rtw_write32(padapter, msgbox_addr, h2c_cmd);



		/* DBG_8192C("MSG_BOX:%d, CmdLen(%d), CmdID(0x%x), reg:0x%x =>h2c_cmd:0x%.8x, reg:0x%x =>h2c_cmd_ex:0x%.8x\n" */

		/* 	, pHalData->LastHMEBoxNum , CmdLen, ElementID, msgbox_addr, h2c_cmd, msgbox_ex_addr, h2c_cmd_ex); */



		pHalData->LastHMEBoxNum = (h2c_box_num+1) % MAX_H2C_BOX_NUMS;



	} while (0);
@@ -852,9 +845,6 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *padapter) 
	u32 TotalPacketLen, MaxRsvdPageBufSize = 0;

	struct rsvdpage_loc RsvdPageLoc;





/* 	DBG_8192C("+" FUNC_ADPT_FMT "\n", FUNC_ADPT_ARG(padapter)); */



	pxmitpriv = &padapter->xmitpriv;

	TxDescLen = TXDESC_SIZE;

	TxDescOffset = TXDESC_OFFSET;
@@ -918,8 +908,6 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *padapter) 
	pattrib->pktlen = pattrib->last_txcmdsz = TotalPacketLen - TxDescOffset;

	dump_mgntframe_and_wait(padapter, pcmdframe, 100);



/* 	DBG_8192C(FUNC_ADPT_FMT ": Set RSVD page location to Fw, TotalPacketLen(%d), TotalPageNum(%d)\n", */

/* 		FUNC_ADPT_ARG(padapter), TotalPacketLen, TotalPageNum); */

	rtl8723b_set_FwRsvdPage_cmd(padapter, &RsvdPageLoc);

	rtl8723b_set_FwAoacRsvdPage_cmd(padapter, &RsvdPageLoc);

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

+0 −21
Original line number Diff line number Diff line
@@ -777,15 +777,12 @@ if (0) { 
		if (efuseHeader == 0xFF) {

			break;

		}

		/* DBG_8192C("%s: efuse[0x%X]= 0x%02X\n", __func__, eFuse_Addr-1, efuseHeader); */



		/*  Check PG header for section num. */

		if (EXT_HEADER(efuseHeader)) { /* extended header */

			offset = GET_HDR_OFFSET_2_0(efuseHeader);

			/* DBG_8192C("%s: extended header offset = 0x%X\n", __func__, offset); */



			efuse_OneByteRead(padapter, eFuse_Addr++, &efuseExtHdr, bPseudoTest);

			/* DBG_8192C("%s: efuse[0x%X]= 0x%02X\n", __func__, eFuse_Addr-1, efuseExtHdr); */

			if (ALL_WORDS_DISABLED(efuseExtHdr))

				continue;
@@ -795,23 +792,19 @@ if (0) { 
			offset = ((efuseHeader >> 4) & 0x0f);

			wden = (efuseHeader & 0x0f);

		}

		/* DBG_8192C("%s: Offset =%d Worden = 0x%X\n", __func__, offset, wden); */



		if (offset < EFUSE_MAX_SECTION_8723B) {

			u16 addr;

			/*  Get word enable value from PG header */

/* 			DBG_8192C("%s: Offset =%d Worden = 0x%X\n", __func__, offset, wden); */



			addr = offset * PGPKT_DATA_SIZE;

			for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) {

				/*  Check word enable condition in the section */

				if (!(wden & (0x01<<i))) {

					efuse_OneByteRead(padapter, eFuse_Addr++, &efuseData, bPseudoTest);

/* 					DBG_8192C("%s: efuse[%#X]= 0x%02X\n", __func__, eFuse_Addr-1, efuseData); */

					efuseTbl[addr] = efuseData;



					efuse_OneByteRead(padapter, eFuse_Addr++, &efuseData, bPseudoTest);

/* 					DBG_8192C("%s: efuse[%#X]= 0x%02X\n", __func__, eFuse_Addr-1, efuseData); */

					efuseTbl[addr+1] = efuseData;

				}

				addr += 2;
@@ -1225,8 +1218,6 @@ static u8 Hal_EfuseWordEnableDataWrite( 
	u8 badworden = 0x0F;

	u8 tmpdata[PGPKT_DATA_SIZE];





/* 	DBG_8192C("%s: efuse_addr =%#x word_en =%#x\n", __func__, efuse_addr, word_en); */

	memset(tmpdata, 0xFF, PGPKT_DATA_SIZE);



	if (!(word_en & BIT(0))) {
@@ -1338,11 +1329,9 @@ static s32 Hal_EfusePgPacketRead( 
				/*  Check word enable condition in the section */

				if (!(hworden & (0x01<<i))) {

					efuse_OneByteRead(padapter, efuse_addr++, &efuse_data, bPseudoTest);

/* 					DBG_8192C("%s: efuse[%#X]= 0x%02X\n", __func__, efuse_addr+tmpidx, efuse_data); */

					data[i*2] = efuse_data;



					efuse_OneByteRead(padapter, efuse_addr++, &efuse_data, bPseudoTest);

/* 					DBG_8192C("%s: efuse[%#X]= 0x%02X\n", __func__, efuse_addr+tmpidx, efuse_data); */

					data[(i*2)+1] = efuse_data;

				}

			}
@@ -1364,7 +1353,6 @@ static u8 hal_EfusePgCheckAvailableAddr( 




	EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_AVAILABLE_EFUSE_BYTES_TOTAL, &max_available, bPseudoTest);

/* 	DBG_8192C("%s: max_available =%d\n", __func__, max_available); */



	current_size = Efuse_GetCurrentSize(padapter, efuseType, bPseudoTest);

	if (current_size >= max_available) {
@@ -1441,7 +1429,6 @@ static u8 hal_EfusePartialWriteCheck( 
				startAddr++;

				efuse_OneByteRead(padapter, startAddr, &efuse_data, bPseudoTest);

				if (ALL_WORDS_DISABLED(efuse_data)) {

					DBG_8192C("%s: Error condition, all words disabled!", __func__);

					bRet = false;

					break;

				} else {
@@ -1462,7 +1449,6 @@ static u8 hal_EfusePartialWriteCheck( 
				(hal_EfuseCheckIfDatafollowed(padapter, curPkt.word_cnts, startAddr+1, bPseudoTest) == false) &&

				wordEnMatched(pTargetPkt, &curPkt, &matched_wden) == true

			) {

				DBG_8192C("%s: Need to partial write data by the previous wrote header\n", __func__);

				/*  Here to write partial data */

				badworden = Efuse_WordEnableDataWrite(padapter, startAddr+1, matched_wden, pTargetPkt->data, bPseudoTest);

				if (badworden != 0x0F) {
@@ -1492,7 +1478,6 @@ static u8 hal_EfusePartialWriteCheck( 
		} else {

			/*  not used header, 0xff */

			*pAddr = startAddr;

/* 			DBG_8192C("%s: Started from unused header offset =%d\n", __func__, startAddr)); */

			bRet = true;

			break;

		}
@@ -1554,7 +1539,6 @@ static u8 hal_EfusePgPacketWrite2ByteHeader( 
	}



	pg_header = ((pTargetPkt->offset & 0x07) << 5) | 0x0F;

/* 	DBG_8192C("%s: pg_header = 0x%x\n", __func__, pg_header); */



	do {

		efuse_OneByteWrite(padapter, efuse_addr, pg_header, bPseudoTest);
@@ -1629,7 +1613,6 @@ static u8 hal_EfusePgPacketWriteData( 
		return false;

	}



/* 	DBG_8192C("%s: ok\n", __func__); */

	return true;

}
@@ -2683,8 +2666,6 @@ static u8 fill_txdesc_sectype(struct pkt_attrib *pattrib) 


static void fill_txdesc_vcs_8723b(struct adapter *padapter, struct pkt_attrib *pattrib, struct txdesc_8723b *ptxdesc)

{

	/* DBG_8192C("cvs_mode =%d\n", pattrib->vcs_mode); */



	if (pattrib->vcs_mode) {

		switch (pattrib->vcs_mode) {

		case RTS_CTS:
@@ -2716,8 +2697,6 @@ static void fill_txdesc_vcs_8723b(struct adapter *padapter, struct pkt_attrib *p 


static void fill_txdesc_phy_8723b(struct adapter *padapter, struct pkt_attrib *pattrib, struct txdesc_8723b *ptxdesc)

{

	/* DBG_8192C("bwmode =%d, ch_off =%d\n", pattrib->bwmode, pattrib->ch_offset); */



	if (pattrib->ht_en) {

		ptxdesc->data_bw = BWMapping_8723B(padapter, pattrib);