Commit 33fff97c authored by Li Heng's avatar Li Heng Committed by Martin K. Petersen
Browse files

scsi: mptfc: Remove unneeded cast from memory allocation 

Remove casting the values returned by memory allocation function.

Coccinelle emits WARNING:

./drivers/message/fusion/mptfc.c:766:17-30: WARNING: casting value returned by memory allocation function to (FCPortPage0_t *) is useless.
./drivers/message/fusion/mptfc.c:907:17-30: WARNING: casting value returned by memory allocation function to (FCPortPage1_t *) is useless.

[mkp: memset()]

Link: https://lore.kernel.org/r/1596014354-59935-1-git-send-email-liheng40@huawei.com


Signed-off-by: default avatarLi Heng <liheng40@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 460d74a0

drivers/message/fusion/mptfc.c

+2 −4
Original line number Diff line number Diff line
@@ -763,7 +763,7 @@ mptfc_GetFcPortPage0(MPT_ADAPTER *ioc, int portnum) 


	data_sz = hdr.PageLength * 4;

	rc = -ENOMEM;

	ppage0_alloc = (FCPortPage0_t *) pci_alloc_consistent(ioc->pcidev, data_sz, &page0_dma);

	ppage0_alloc = pci_alloc_consistent(ioc->pcidev, data_sz, &page0_dma);

	if (ppage0_alloc) {



 try_again:
@@ -904,7 +904,7 @@ mptfc_GetFcPortPage1(MPT_ADAPTER *ioc, int portnum) 
		if (data_sz < sizeof(FCPortPage1_t))

			data_sz = sizeof(FCPortPage1_t);



		page1_alloc = (FCPortPage1_t *) pci_alloc_consistent(ioc->pcidev,

		page1_alloc = pci_alloc_consistent(ioc->pcidev,

						data_sz,

						&page1_dma);

		if (!page1_alloc)
@@ -922,8 +922,6 @@ mptfc_GetFcPortPage1(MPT_ADAPTER *ioc, int portnum) 
		}

	}



	memset(page1_alloc,0,data_sz);



	cfg.physAddr = page1_dma;

	cfg.action = MPI_CONFIG_ACTION_PAGE_READ_CURRENT;