Unverified Commit 34d27c71 authored by Cezary Rojewski's avatar Cezary Rojewski Committed by Mark Brown
Browse files

ASoC: Intel: avs: Gather remaining logs on strace_release() 



When user closes the tracer, some logs may still remain in the tail of
the buffer as firmware sends LOG_BUFFER_STATUS notification only when
certain threshold of data is reached. Add whatever is left to already
gathered logs so no information is lost.

Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20221202152841.672536-15-cezary.rojewski@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5a565ba2

sound/soc/intel/avs/debugfs.c

+15 −1
Original line number Diff line number Diff line
@@ -201,11 +201,25 @@ static int strace_open(struct inode *inode, struct file *file) 


static int strace_release(struct inode *inode, struct file *file)

{

	union avs_notify_msg msg = AVS_NOTIFICATION(LOG_BUFFER_STATUS);

	struct avs_dev *adev = file->private_data;

	unsigned long flags;

	unsigned long resource_mask;

	unsigned long flags, i;

	u32 num_cores;



	resource_mask = adev->logged_resources;

	num_cores = adev->hw_cfg.dsp_cores;



	spin_lock_irqsave(&adev->trace_lock, flags);



	/* Gather any remaining logs. */

	for_each_set_bit(i, &resource_mask, num_cores) {

		msg.log.core = i;

		avs_dsp_op(adev, log_buffer_status, &msg);

	}



	kfifo_free(&adev->trace_fifo);



	spin_unlock_irqrestore(&adev->trace_lock, flags);



	return 0;