Commit 351e458f authored by Bart Van Assche's avatar Bart Van Assche Committed by Leon Romanovsky
Browse files

RDMA/srp: Handle dev_set_name() failure 

Instead of ignoring dev_set_name() failure, handle dev_set_name()
failure. Convert a device_register() call into device_initialize() and
device_add() calls.

Link: https://lore.kernel.org/r/20220825213900.864587-4-bvanassche@acm.org


Reported-by: default avatarBo Liu <liubo03@inspur.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 0766fcaa

drivers/infiniband/ulp/srp/ib_srp.c

+5 −4
Original line number Diff line number Diff line
@@ -3902,12 +3902,13 @@ static struct srp_host *srp_add_port(struct srp_device *device, u8 port) 
	host->srp_dev = device;

	host->port = port;



	device_initialize(&host->dev);

	host->dev.class = &srp_class;

	host->dev.parent = device->dev->dev.parent;

	dev_set_name(&host->dev, "srp-%s-%d", dev_name(&device->dev->dev),

		     port);



	if (device_register(&host->dev))

	if (dev_set_name(&host->dev, "srp-%s-%d", dev_name(&device->dev->dev),

			 port))

		goto put_host;

	if (device_add(&host->dev))

		goto put_host;

	if (device_create_file(&host->dev, &dev_attr_add_target))

		goto put_host;