Commit 36000c7a authored by Tian Tao's avatar Tian Tao Committed by Alex Deucher
Browse files

drm/amdgpu: Convert sysfs sprintf/snprintf family to sysfs_emit 



Fix the following coccicheck warning:
drivers/gpu//drm/amd/amdgpu/amdgpu_ras.c:434:9-17: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_xgmi.c:220:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_xgmi.c:249:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/df_v3_6.c:208:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_psp.c:2973:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_vram_mgr.c:75:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_vram_mgr.c:112:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_vram_mgr.c:58:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_vram_mgr.c:93:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_vram_mgr.c:125:9-17: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_gtt_mgr.c:52:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_gtt_mgr.c:71:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_device.c:140:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_device.c:164:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_device.c:186:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_device.c:208:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu//drm/amd/amdgpu/amdgpu_atombios.c:1916:8-16: WARNING:
use scnprintf or sprintf

Signed-off-by: default avatarTian Tao <tiantao6@hisilicon.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 2b0e617a

drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c

+1 −1
Original line number Diff line number Diff line
@@ -1913,7 +1913,7 @@ static ssize_t amdgpu_atombios_get_vbios_version(struct device *dev, 
	struct amdgpu_device *adev = drm_to_adev(ddev);

	struct atom_context *ctx = adev->mode_info.atom_context;



	return snprintf(buf, PAGE_SIZE, "%s\n", ctx->vbios_version);

	return sysfs_emit(buf, "%s\n", ctx->vbios_version);

}



static DEVICE_ATTR(vbios_version, 0444, amdgpu_atombios_get_vbios_version,

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

+4 −4
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ static ssize_t amdgpu_device_get_pcie_replay_count(struct device *dev, 
	struct amdgpu_device *adev = drm_to_adev(ddev);

	uint64_t cnt = amdgpu_asic_get_pcie_replay_count(adev);



	return snprintf(buf, PAGE_SIZE, "%llu\n", cnt);

	return sysfs_emit(buf, "%llu\n", cnt);

}



static DEVICE_ATTR(pcie_replay_count, S_IRUGO,
@@ -161,7 +161,7 @@ static ssize_t amdgpu_device_get_product_name(struct device *dev, 
	struct drm_device *ddev = dev_get_drvdata(dev);

	struct amdgpu_device *adev = drm_to_adev(ddev);



	return snprintf(buf, PAGE_SIZE, "%s\n", adev->product_name);

	return sysfs_emit(buf, "%s\n", adev->product_name);

}



static DEVICE_ATTR(product_name, S_IRUGO,
@@ -183,7 +183,7 @@ static ssize_t amdgpu_device_get_product_number(struct device *dev, 
	struct drm_device *ddev = dev_get_drvdata(dev);

	struct amdgpu_device *adev = drm_to_adev(ddev);



	return snprintf(buf, PAGE_SIZE, "%s\n", adev->product_number);

	return sysfs_emit(buf, "%s\n", adev->product_number);

}



static DEVICE_ATTR(product_number, S_IRUGO,
@@ -205,7 +205,7 @@ static ssize_t amdgpu_device_get_serial_number(struct device *dev, 
	struct drm_device *ddev = dev_get_drvdata(dev);

	struct amdgpu_device *adev = drm_to_adev(ddev);



	return snprintf(buf, PAGE_SIZE, "%s\n", adev->serial);

	return sysfs_emit(buf, "%s\n", adev->serial);

}



static DEVICE_ATTR(serial_number, S_IRUGO,

drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c

+2 −4
Original line number Diff line number Diff line
@@ -49,8 +49,7 @@ static ssize_t amdgpu_mem_info_gtt_total_show(struct device *dev, 
	struct amdgpu_device *adev = drm_to_adev(ddev);

	struct ttm_resource_manager *man = ttm_manager_type(&adev->mman.bdev, TTM_PL_TT);



	return snprintf(buf, PAGE_SIZE, "%llu\n",

			man->size * PAGE_SIZE);

	return sysfs_emit(buf, "%llu\n", man->size * PAGE_SIZE);

}



/**
@@ -68,8 +67,7 @@ static ssize_t amdgpu_mem_info_gtt_used_show(struct device *dev, 
	struct amdgpu_device *adev = drm_to_adev(ddev);

	struct ttm_resource_manager *man = ttm_manager_type(&adev->mman.bdev, TTM_PL_TT);



	return snprintf(buf, PAGE_SIZE, "%llu\n",

			amdgpu_gtt_mgr_usage(man));

	return sysfs_emit(buf, "%llu\n", amdgpu_gtt_mgr_usage(man));

}



static DEVICE_ATTR(mem_info_gtt_total, S_IRUGO,

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

+1 −1
Original line number Diff line number Diff line
@@ -2993,7 +2993,7 @@ static ssize_t psp_usbc_pd_fw_sysfs_read(struct device *dev, 
		return ret;

	}



	return snprintf(buf, PAGE_SIZE, "%x\n", fw_ver);

	return sysfs_emit(buf, "%x\n", fw_ver);

}



static ssize_t psp_usbc_pd_fw_sysfs_write(struct device *dev,

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

+3 −5
Original line number Diff line number Diff line
@@ -431,14 +431,12 @@ static ssize_t amdgpu_ras_sysfs_read(struct device *dev, 
	};



	if (!amdgpu_ras_get_error_query_ready(obj->adev))

		return snprintf(buf, PAGE_SIZE,

				"Query currently inaccessible\n");

		return sysfs_emit(buf, "Query currently inaccessible\n");



	if (amdgpu_ras_query_error_status(obj->adev, &info))

		return -EINVAL;



	return snprintf(buf, PAGE_SIZE, "%s: %lu\n%s: %lu\n",

			"ue", info.ue_count,

	return sysfs_emit(buf, "%s: %lu\n%s: %lu\n", "ue", info.ue_count,

			  "ce", info.ce_count);

}