Unverified Commit 360fa323 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: debug/ops: Move the IPC and DSP dump functions out from the header 



To be usable in platform code, move the IPC and DSP dump function to
debug.c and export it in a similar way as the snd_sof_handle_fw_exception()

Make the snd_sof_ipc_dump() static as it is only used in debug.c

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211006110645.26679-8-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e131bc58

sound/soc/sof/debug.c

+23 −0
Original line number Diff line number Diff line
@@ -822,6 +822,29 @@ void snd_sof_free_debug(struct snd_sof_dev *sdev) 
}

EXPORT_SYMBOL_GPL(snd_sof_free_debug);



void snd_sof_dsp_dbg_dump(struct snd_sof_dev *sdev, u32 flags)

{

	if (sof_ops(sdev)->dbg_dump && !sdev->dbg_dump_printed) {

		dev_err(sdev->dev, "------------[ DSP dump start ]------------\n");

		sof_ops(sdev)->dbg_dump(sdev, flags);

		dev_err(sdev->dev, "------------[ DSP dump end ]------------\n");

		if (!(sof_core_debug & SOF_DBG_PRINT_ALL_DUMPS))

			sdev->dbg_dump_printed = true;

	}

}

EXPORT_SYMBOL(snd_sof_dsp_dbg_dump);



static void snd_sof_ipc_dump(struct snd_sof_dev *sdev)

{

	if (sof_ops(sdev)->ipc_dump  && !sdev->ipc_dump_printed) {

		dev_err(sdev->dev, "------------[ IPC dump start ]------------\n");

		sof_ops(sdev)->ipc_dump(sdev);

		dev_err(sdev->dev, "------------[ IPC dump end ]------------\n");

		if (!(sof_core_debug & SOF_DBG_PRINT_ALL_DUMPS))

			sdev->ipc_dump_printed = true;

	}

}



void snd_sof_handle_fw_exception(struct snd_sof_dev *sdev)

{

	if (IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_RETAIN_DSP_CONTEXT) ||

sound/soc/sof/ops.h

+1 −21
Original line number Diff line number Diff line
@@ -241,27 +241,7 @@ snd_sof_dsp_set_power_state(struct snd_sof_dev *sdev, 
}



/* debug */

static inline void snd_sof_dsp_dbg_dump(struct snd_sof_dev *sdev, u32 flags)

{

	if (sof_ops(sdev)->dbg_dump && !sdev->dbg_dump_printed) {

		dev_err(sdev->dev, "------------[ DSP dump start ]------------\n");

		sof_ops(sdev)->dbg_dump(sdev, flags);

		dev_err(sdev->dev, "------------[ DSP dump end ]------------\n");

		if (!(sof_core_debug & SOF_DBG_PRINT_ALL_DUMPS))

			sdev->dbg_dump_printed = true;

	}

}



static inline void snd_sof_ipc_dump(struct snd_sof_dev *sdev)

{

	if (sof_ops(sdev)->ipc_dump  && !sdev->ipc_dump_printed) {

		dev_err(sdev->dev, "------------[ IPC dump start ]------------\n");

		sof_ops(sdev)->ipc_dump(sdev);

		dev_err(sdev->dev, "------------[ IPC dump end ]------------\n");

		if (!(sof_core_debug & SOF_DBG_PRINT_ALL_DUMPS))

			sdev->ipc_dump_printed = true;

	}

}

void snd_sof_dsp_dbg_dump(struct snd_sof_dev *sdev, u32 flags);



static inline int snd_sof_debugfs_add_region_item(struct snd_sof_dev *sdev,

		enum snd_sof_fw_blk_type blk_type, u32 offset, size_t size,