Commit 36217357 authored by Joe Perches's avatar Joe Perches Committed by Andrew Morton
Browse files

checkpatch: improve EMBEDDED_FILENAME test 

Privately, Heinz Mauelshagen showed that the embedded filename test is not
specific enough.

> WARNING: It's generally not useful to have the filename in the file
> #113: FILE: errors.c:113:
> +            block < registered_errors.blocks + registered_errors.count;

Extend the test to use the appropriate word boundary tests.

Link: https://lkml.kernel.org/r/36069dac5d07509dab1c7f1238f8cbb08db80ac6.camel@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reported-by: default avatarHeinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 3ee2a3e7

scripts/checkpatch.pl

+1 −1
Original line number Diff line number Diff line
@@ -3751,7 +3751,7 @@ sub process { 
		}



# check for embedded filenames

		if ($rawline =~ /^\+.*\Q$realfile\E/) {

		if ($rawline =~ /^\+.*\b\Q$realfile\E\b/) {

			WARN("EMBEDDED_FILENAME",

			     "It's generally not useful to have the filename in the file\n" . $herecurr);

		}