Commit 36941dfe authored by Dan Carpenter's avatar Dan Carpenter Committed by Jason Gunthorpe
Browse files

RDMA/rxe: Missing unlock on error in get_srq_wqe() 

This error path needs to unlock before returning.

Fixes: ec0fa244 ("RDMA/rxe: Fix over copying in get_srq_wqe")
Link: https://lore.kernel.org/r/YNXUCmnPsSkPyhkm@mwanda


Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarMajd Dibbiny <majd@nvidia.com>
Reviewed-by: default avatarBob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 74f160ea

drivers/infiniband/sw/rxe/rxe_resp.c

+1 −0
Original line number Diff line number Diff line
@@ -314,6 +314,7 @@ static enum resp_states get_srq_wqe(struct rxe_qp *qp) 


	/* don't trust user space data */

	if (unlikely(wqe->dma.num_sge > srq->rq.max_sge)) {

		spin_unlock_bh(&srq->rq.consumer_lock);

		pr_warn("%s: invalid num_sge in SRQ entry\n", __func__);

		return RESPST_ERR_MALFORMED_WQE;

	}