Commit 3836c73e authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: sim: fix setting and getting multiple lines 



We need to take mask into account in the set/get_multiple() callbacks.
Use bitmap_replace() instead of bitmap_copy().

Fixes: cb8c474e ("gpio: sim: new testing module")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent ce522ba9

drivers/gpio/gpio-sim.c

+2 −2
Original line number Diff line number Diff line
@@ -134,7 +134,7 @@ static int gpio_sim_get_multiple(struct gpio_chip *gc, 
	struct gpio_sim_chip *chip = gpiochip_get_data(gc);



	mutex_lock(&chip->lock);

	bitmap_copy(bits, chip->value_map, gc->ngpio);

	bitmap_replace(bits, bits, chip->value_map, mask, gc->ngpio);

	mutex_unlock(&chip->lock);



	return 0;
@@ -146,7 +146,7 @@ static void gpio_sim_set_multiple(struct gpio_chip *gc, 
	struct gpio_sim_chip *chip = gpiochip_get_data(gc);



	mutex_lock(&chip->lock);

	bitmap_copy(chip->value_map, bits, gc->ngpio);

	bitmap_replace(chip->value_map, chip->value_map, bits, mask, gc->ngpio);

	mutex_unlock(&chip->lock);

}