Commit 38d676da authored Oct 20, 2014 by Vaishali Thakkar Committed by Greg Kroah-Hartman Oct 23, 2014

Staging: lustre: Remove typedef ldlm_ns_hash_def_t



The linux kernel coding style guidelines suggest not using typedefs
for structure types. This patch gets rid of the typedef for
ldlm_ns_hash_def_t. Also, the name of the struct is changed to drop
the _t, to make the name look less typedef-like.

This is done using Coccinelle. Semantic patch used to detect this
case is as follows:

@tn1@
type td;
@@

typedef struct { ... } td;

@script:python tf@
td << tn1.td;
tdres;
@@

coccinelle.tdres = td;

@@
type tn1.td;
identifier tf.tdres;
@@

-typedef
 struct
+  tdres
   { ... }
-td
 ;

@@
type tn1.td;
identifier tf.tdres;
@@
-td
+ struct tdres

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 09512525

drivers/staging/lustre/lustre/ldlm/ldlm_resource.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -501,7 +501,7 @@ cfs_hash_ops_t ldlm_ns_fid_hash_ops = {
		.hs_put = ldlm_res_hop_put
		};

		typedef struct {
		struct ldlm_ns_hash_def {
		ldlm_ns_type_t nsd_type;
		/** hash bucket bits */
		unsigned nsd_bkt_bits;
		@@ -509,9 +509,9 @@ typedef struct {
		unsigned nsd_all_bits;
		/** hash operations */
		cfs_hash_ops_t *nsd_hops;
		} ldlm_ns_hash_def_t;
		};

		ldlm_ns_hash_def_t ldlm_ns_hash_defs[] = {
		struct ldlm_ns_hash_def ldlm_ns_hash_defs[] = {
		{
		.nsd_type = LDLM_NS_TYPE_MDC,
		.nsd_bkt_bits = 11,
		@@ -563,7 +563,7 @@ struct ldlm_namespace ldlm_namespace_new(struct obd_device obd, char *name,
		{
		struct ldlm_namespace *ns = NULL;
		struct ldlm_ns_bucket *nsb;
		ldlm_ns_hash_def_t *nsd;
		struct ldlm_ns_hash_def *nsd;
		struct cfs_hash_bd bd;
		int idx;
		int rc;