Commit 39266b64 authored by Biju Das's avatar Biju Das Committed by William Breathitt Gray
Browse files

counter: rz-mtu3-cnt: Reorder locking sequence for consistency 



All functions except rz_mtu3_count_enable_write(), call
pm_runtime_{get,put} inside the lock. For consistency do the same here.

Reported-by: default avatarPavel Machek <pavel@denx.de>
Closes: https://lore.kernel.org/r/ZH8Fmom8vZ4DwxqA@duo.ucw.cz


Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230725154611.227556-1-biju.das.jz@bp.renesas.com/


Signed-off-by: default avatarWilliam Breathitt Gray <william.gray@linaro.org>
parent 3a913880

drivers/counter/rz-mtu3-cnt.c

+2 −2
Original line number Diff line number Diff line
@@ -500,8 +500,8 @@ static int rz_mtu3_count_enable_write(struct counter_device *counter, 
	int ret = 0;



	if (enable) {

		pm_runtime_get_sync(ch->dev);

		mutex_lock(&priv->lock);

		pm_runtime_get_sync(ch->dev);

		ret = rz_mtu3_initialize_counter(counter, count->id);

		if (ret == 0)

			priv->count_is_enabled[count->id] = true;
@@ -510,8 +510,8 @@ static int rz_mtu3_count_enable_write(struct counter_device *counter, 
		mutex_lock(&priv->lock);

		rz_mtu3_terminate_counter(counter, count->id);

		priv->count_is_enabled[count->id] = false;

		mutex_unlock(&priv->lock);

		pm_runtime_put(ch->dev);

		mutex_unlock(&priv->lock);

	}



	return ret;