Commit 397d3415 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

greybus: raw: fix memory leak on disconnect 



Make sure the class device is freed as well as deregistered on
disconnect.

Also deregister the class device before character device as the former
depends on the latter.

Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 8d46ec49

drivers/staging/greybus/raw.c

+1 −1
Original line number Diff line number Diff line
@@ -203,9 +203,9 @@ static void gb_raw_connection_exit(struct gb_connection *connection) 
	struct raw_data *temp;



	// FIXME - handle removing a connection when the char device node is open.

	device_destroy(raw_class, raw->dev);

	cdev_del(&raw->cdev);

	ida_simple_remove(&minors, MINOR(raw->dev));

	device_del(raw->device);

	mutex_lock(&raw->list_lock);

	list_for_each_entry_safe(raw_data, temp, &raw->list, entry) {

		list_del(&raw_data->entry);