Commit 3a3a1004 authored by Bjorn Andersson's avatar Bjorn Andersson Committed by Linus Walleij
Browse files

pinctrl: qcom: sdm845: Enable dual edge errata 



It has been observed that dual edge triggered wakeirq GPIOs on SDM845
doesn't trigger interrupts on the falling edge.

Enabling wakeirq_dual_edge_errata for SDM845 indicates that the PDC in
SDM845 suffers from the same problem described, and worked around, by
Doug in 'c3c0c2e1 ("pinctrl: qcom: Handle broken/missing PDC dual
edge IRQs on sc7180")', so enable the workaround for SDM845 as well.

The specific problem seen without this is that gpio-keys does not detect
the falling edge of the LID gpio on the Lenovo Yoga C630 and as such
consistently reports the LID as closed.

Fixes: e35a6ae0 ("pinctrl/msm: Setup GPIO chip in hierarchy")
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Tested-By: default avatarSteev Klimaszewski <steev@kali.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20211102034115.1946036-1-bjorn.andersson@linaro.org


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 9b3b94e9

drivers/pinctrl/qcom/pinctrl-sdm845.c

+1 −0
Original line number Diff line number Diff line
@@ -1310,6 +1310,7 @@ static const struct msm_pinctrl_soc_data sdm845_pinctrl = { 
	.ngpios = 151,

	.wakeirq_map = sdm845_pdc_map,

	.nwakeirq_map = ARRAY_SIZE(sdm845_pdc_map),

	.wakeirq_dual_edge_errata = true,

};



static const struct msm_pinctrl_soc_data sdm845_acpi_pinctrl = {