Commit 3bde235b authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: fix __get_frame_info() error handling 

On ia_css_pipe_get_info() errors, destroy both the streams as well
as the pipes which were created.

Link: https://lore.kernel.org/linux-media/20220615205037.16549-34-hdegoede@redhat.com


Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 3a68900a

drivers/staging/media/atomisp/pci/atomisp_compat_css20.c

+3 −1
Original line number Diff line number Diff line
@@ -2653,7 +2653,7 @@ static int __get_frame_info(struct atomisp_sub_device *asd, 
				   &p_info);

	if (ret) {

		dev_err(isp->dev, "can't get info from pipe\n");

		goto stream_err;

		goto get_info_err;

	}



	switch (type) {
@@ -2684,6 +2684,8 @@ static int __get_frame_info(struct atomisp_sub_device *asd, 


	return 0;



get_info_err:

	__destroy_streams(asd, true);

stream_err:

	__destroy_pipes(asd, true);

	return -EINVAL;