Commit 3d780c8a authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Herbert Xu
Browse files

crypto: amlogic - Remove kcalloc without check 



There is no real point in allocating dedicated memory for the irqs array.
MAXFLOW is only 2, so it is easier to allocated the needed space
directly within the 'meson_dev' structure.

This saves some memory allocation and avoids an indirection when using the
irqs array.

Fixes: 48fe583f ("crypto: amlogic - Add crypto accelerator...")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 4d2b225a

drivers/crypto/amlogic/amlogic-gxl-core.c

+0 −1
Original line number Diff line number Diff line
@@ -237,7 +237,6 @@ static int meson_crypto_probe(struct platform_device *pdev) 
		return err;

	}



	mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL);

	for (i = 0; i < MAXFLOW; i++) {

		mc->irqs[i] = platform_get_irq(pdev, i);

		if (mc->irqs[i] < 0)

drivers/crypto/amlogic/amlogic-gxl.h

+1 −1
Original line number Diff line number Diff line
@@ -95,7 +95,7 @@ struct meson_dev { 
	struct device *dev;

	struct meson_flow *chanlist;

	atomic_t flow;

	int *irqs;

	int irqs[MAXFLOW];

#ifdef CONFIG_CRYPTO_DEV_AMLOGIC_GXL_DEBUG

	struct dentry *dbgfs_dir;

#endif