Commit 3d9b1421 authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso
Browse files

netfilter: nft_compat: call {target, match}->destroy() to cleanup entry 



Otherwise, the reference to external objects (eg. modules) are not
released when the rules are removed.

Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent ac904ac8

net/netfilter/nft_compat.c

+18 −0
Original line number Original line Diff line number Diff line
@@ -195,6 +195,15 @@ static void 
nft_target_destroy(const struct nft_ctx *ctx, const struct nft_expr *expr)

nft_target_destroy(const struct nft_ctx *ctx, const struct nft_expr *expr)

{

{

	struct xt_target *target = expr->ops->data;

	struct xt_target *target = expr->ops->data;

	void *info = nft_expr_priv(expr);

	struct xt_tgdtor_param par;



	par.net = ctx->net;

	par.target = target;

	par.targinfo = info;

	par.family = ctx->afi->family;

	if (par.target->destroy != NULL)

		par.target->destroy(&par);





	module_put(target->me);

	module_put(target->me);

}

}
@@ -382,6 +391,15 @@ static void 
nft_match_destroy(const struct nft_ctx *ctx, const struct nft_expr *expr)

nft_match_destroy(const struct nft_ctx *ctx, const struct nft_expr *expr)

{

{

	struct xt_match *match = expr->ops->data;

	struct xt_match *match = expr->ops->data;

	void *info = nft_expr_priv(expr);

	struct xt_mtdtor_param par;



	par.net = ctx->net;

	par.match = match;

	par.matchinfo = info;

	par.family = ctx->afi->family;

	if (par.match->destroy != NULL)

		par.match->destroy(&par);





	module_put(match->me);

	module_put(match->me);

}

}