Commit 3f122df4 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: vivid: do not implement VIDIOC_S_PARM for output streams 



v4l2_compliance gave a warning for the S_PARM test for output streams:

warn: v4l2-test-formats.cpp(1235): S_PARM is supported for buftype 2, but not for ENUM_FRAMEINTERVALS

The reason is that vivid mapped s_parm for output streams to g_parm. But if
S_PARM doesn't actually change anything, then it shouldn't be enabled at all.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 987303cc

drivers/media/platform/vivid/vivid-core.c

+1 −1
Original line number Diff line number Diff line
@@ -371,7 +371,7 @@ static int vidioc_s_parm(struct file *file, void *fh, 


	if (vdev->vfl_dir == VFL_DIR_RX)

		return vivid_vid_cap_s_parm(file, fh, parm);

	return vivid_vid_out_g_parm(file, fh, parm);

	return -ENOTTY;

}



static int vidioc_log_status(struct file *file, void *fh)